1578732 - Perma /builds/worker/workspace/build/src/security/manager/ssl/RootCertificateTelemetryUtils.cpp:84:52: error: use of undeclared identifier '<various>' when Gecko 71 merges to Beta on 2019-10-14

Status: VERIFIED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: shindli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=264930996&repo=try
Full log: https://queue.taskcluster.net/v1/task/PVApI2i7QPG697F-PIcQew/runs/0/artifacts/public/logs/live_backing.log

---

task 2019-09-04T12:15:23.759Z] 12:15:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/osfile'
[task 2019-09-04T12:15:23.759Z] 12:15:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/clearsitedata'
[task 2019-09-04T12:15:23.759Z] 12:15:23 INFO - /builds/worker/fetches/clang/bin/clang++ -std=gnu++14 -o Unified_cpp_clearsitedata0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/toolkit/components/clearsitedata -I/builds/worker/workspace/build/src/obj-firefox/toolkit/components/clearsitedata -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fomit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/Unified_cpp_clearsitedata0.o.pp /builds/worker/workspace/build/src/obj-firefox/toolkit/components/clearsitedata/Unified_cpp_clearsitedata0.cpp
[task 2019-09-04T12:15:23.759Z] 12:15:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/clearsitedata'
[task 2019-09-04T12:15:23.767Z] 12:15:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/parentalcontrols'
[task 2019-09-04T12:15:23.767Z] 12:15:23 INFO - mkdir -p '.deps/'
[task 2019-09-04T12:15:23.768Z] 12:15:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/parentalcontrols'
[task 2019-09-04T12:15:23.768Z] 12:15:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/osfile'
[task 2019-09-04T12:15:23.768Z] 12:15:23 INFO - toolkit/components/osfile/NativeOSFileInternals.o
[task 2019-09-04T12:15:23.768Z] 12:15:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/osfile'
[task 2019-09-04T12:15:23.783Z] 12:15:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/parentalcontrols'
[task 2019-09-04T12:15:23.783Z] 12:15:23 INFO - toolkit/components/parentalcontrols/nsParentalControlsServiceDefault.o
[task 2019-09-04T12:15:23.783Z] 12:15:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/parentalcontrols'
[task 2019-09-04T12:15:23.831Z] 12:15:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/browser'
[task 2019-09-04T12:15:23.834Z] 12:15:23 INFO - /builds/worker/fetches/clang/bin/clang++ -std=gnu++14 -o Unified_cpp_components_browser0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/toolkit/components/browser -I/builds/worker/workspace/build/src/obj-firefox/toolkit/components/browser -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/docshell/base -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/svg -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fomit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -MD -MP -MF .deps/Unified_cpp_components_browser0.o.pp /builds/worker/workspace/build/src/obj-firefox/toolkit/components/browser/Unified_cpp_components_browser0.cpp
[task 2019-09-04T12:15:23.835Z] 12:15:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/browser'
[task 2019-09-04T12:15:23.850Z] 12:15:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/perfmonitoring'
[task 2019-09-04T12:15:23.851Z] 12:15:23 INFO - mkdir -p '.deps/'
[task 2019-09-04T12:15:23.851Z] 12:15:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/perfmonitoring'
[task 2019-09-04T12:15:23.851Z] 12:15:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/perfmonitoring'
[task 2019-09-04T12:15:23.851Z] 12:15:23 INFO - toolkit/components/perfmonitoring/Unified_cpp_perfmonitoring0.o
[task 2019-09-04T12:15:23.852Z] 12:15:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/perfmonitoring'
[task 2019-09-04T12:15:24.310Z] 12:15:24 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/security/manager/ssl'
[task 2019-09-04T12:15:24.311Z] 12:15:24 INFO - /builds/worker/fetches/clang/bin/clang++ -std=gnu++14 -o Unified_cpp_security_manager_ssl1.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES=True -DNSS_ENABLE_ECC=True -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/security/manager/ssl -I/builds/worker/workspace/build/src/obj-firefox/security/manager/ssl -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/crypto -I/builds/worker/workspace/build/src/security/certverifier -I/builds/worker/workspace/build/src/obj-firefox/dist/public/nss -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fomit-frame-pointer -funwind-tables -Werror -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -MD -MP -MF .deps/Unified_cpp_security_manager_ssl1.o.pp /builds/worker/workspace/build/src/obj-firefox/security/manager/ssl/Unified_cpp_security_manager_ssl1.cpp
[task 2019-09-04T12:15:24.311Z] 12:15:24 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/security/manager/ssl/Unified_cpp_security_manager_ssl1.cpp:2:
[task 2019-09-04T12:15:24.311Z] 12:15:24 ERROR - /builds/worker/workspace/build/src/security/manager/ssl/RootCertificateTelemetryUtils.cpp:84:52: error: use of undeclared identifier 'kRootModuleName'
[task 2019-09-04T12:15:24.312Z] 12:15:24 INFO - UniqueSECMODModule rootsModule(SECMOD_FindModule(kRootModuleName));
[task 2019-09-04T12:15:24.312Z] 12:15:24 INFO - ^
[task 2019-09-04T12:15:24.312Z] 12:15:24 ERROR - /builds/worker/workspace/build/src/security/manager/ssl/RootCertificateTelemetryUtils.cpp:91:12: error: use of undeclared identifier 'nsINSSComponent'
[task 2019-09-04T12:15:24.312Z] 12:15:24 INFO - nsCOMPtr<nsINSSComponent> component(do_GetService(PSM_COMPONENT_CONTRACTID));

Comment 1

[Stefan Hindli [:stefan_hindli]]

[Tracking Requested - why for this release]:

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: bug 1578732 - #include more headers in RootCertificateTelemetryUtils.cpp so it can compile when chunking changes in unified builds r?KevinJacobs

Comment 3

[Intermittent Failures Robot]

33 failures in 874 pushes (0.038 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 33

Platform breakdown:

• linux64: 8
• android-em-7-0-x86_64: 14
• macosx1014-64: 3
• linux64-qr: 2
• macosx1014-64-shippable: 2
• windows10-64: 2
• windows10-64-qr: 1
• macosx1014-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1578732&startday=2019-09-04&endday=2019-09-04&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/addb15a90da7
#include more headers in RootCertificateTelemetryUtils.cpp so it can compile when chunking changes in unified builds r=kjacobs

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/addb15a90da7

Comment 6

[Noemi Erli[:noemi_erli]]

Verified fix in today's beta-sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=cb853226098e88a353228488821cf30d3c106ad0&searchStr=build

Comment 7

[Intermittent Failures Robot]

33 failures in 4408 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• try: 33

Platform breakdown:

• linux64: 8
• android-em-7-0-x86_64: 14
• macosx1014-64: 3
• linux64-qr: 2
• macosx1014-64-shippable: 2
• windows10-64: 2
• windows10-64-qr: 1
• macosx1014-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1578732&startday=2019-09-02&endday=2019-09-08&tree=all