1578768 - [Protection Report] icons should fit in a 64 * 64px box

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Erica Wright [:ewright]]

When changing the way the icons were treated due to windows high contrast mode, some sizing was skewed. The icons should all fit inside of a 64 * 64px box. The report Icon is too large.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1578768 - Resize icons to fit in a 64px X 64px area.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09c184a3b14c
Resize icons to fit in a 64px X 64px area. r=johannh

Comment 3

[Erica Wright [:ewright]]

Comment on attachment 9090499 [details]
Bug 1578768 - Resize icons to fit in a 64px X 64px area.

Beta/Release Uplift Approval Request

• User impact if declined: Icon of Enhanced Tracking Protection section is much larger than other icons on the page. Colors on ETP icon are not distinctive enough.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS and SVG change. icons are resized to match and some swapped for a more visually appealing icon.
• String changes made/needed: none

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9090499 [details]
Bug 1578768 - Resize icons to fit in a 64px X 64px area.

Icon fix, skyline related, let's uplift for beta 5.

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c5b72ed6394

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/09c184a3b14c