Closed Bug 1578768 Opened 3 months ago Closed 3 months ago

[Protection Report] icons should fit in a 64 * 64px box

Categories

(Firefox :: Protections UI, defect, P1)

71 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: ewright, Assigned: ewright)

References

(Blocks 1 open bug)

Details

(Whiteboard: [protection-report][skyline])

Attachments

(1 file)

When changing the way the icons were treated due to windows high contrast mode, some sizing was skewed. The icons should all fit inside of a 64 * 64px box. The report Icon is too large.

Whiteboard: [protection-report][skyline]
Assignee: nobody → ewright
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09c184a3b14c
Resize icons to fit in a 64px X 64px area. r=johannh

Comment on attachment 9090499 [details]
Bug 1578768 - Resize icons to fit in a 64px X 64px area.

Beta/Release Uplift Approval Request

  • User impact if declined: Icon of Enhanced Tracking Protection section is much larger than other icons on the page. Colors on ETP icon are not distinctive enough.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS and SVG change. icons are resized to match and some swapped for a more visually appealing icon.
  • String changes made/needed: none
Attachment #9090499 - Flags: approval-mozilla-beta?

Comment on attachment 9090499 [details]
Bug 1578768 - Resize icons to fit in a 64px X 64px area.

Icon fix, skyline related, let's uplift for beta 5.

Attachment #9090499 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.