Closed Bug 1578845 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18845 - [web-animations] Correctly handle parsing and serializing shorthands

Categories

(Core :: DOM: Animation, task, P4)

Product:
Core
Component:
DOM: Animation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18845 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18845
Details from upstream follow.

Majid Valipour <majidvp@chromium.org> wrote:

[web-animations] Correctly handle parsing and serializing shorthands

It is possible to have a long hand that belongs to multiple shorthands
(e.g., border-left-style belongs to border-style which belongs to
border).

This means that our previous approach of using the shorthand from one
of the longhands components in the map is not correct. To fix this
we simply record the original shorthand that these longhands were
parsed for. This ensures correctness.

TEST= external/wpt/web-animations/interfaces/KeyframeEffect/setKeyframes.html
Bug:999855
Change-Id: I42ee78b6b470dacc51fff2fac07b2f09e7b42896
Reviewed-on: https://chromium-review.googlesource.com/1784860
WPT-Export-Revision: 2d344975802ad37bd40127a4cec97a94a5cfed5c

Component: web-platform-tests → DOM: Animation
Product: Testing → Core
Ran 4 tests and 391 subtests OK : 4 PASS : 382 FAIL : 9 New tests that have failures or other problems: /web-animations/interfaces/Animatable/animate.html Element.animate() accepts a two property (one shorthand and one of its shorthand components) two value property-indexed keyframes specification: FAIL /web-animations/interfaces/KeyframeEffect/constructor.html A KeyframeEffect can be constructed with a keyframe sequence with a CSS variable as its property: FAIL[linux64-qr-opt] A KeyframeEffect can be constructed with a property-indexed keyframes specification with a CSS variable as the property: FAIL[linux64-qr-opt] A KeyframeEffect can be constructed with a two property (one shorthand and one of its shorthand components) two value property-indexed keyframes specification: FAIL /web-animations/interfaces/KeyframeEffect/setKeyframes.html Keyframes can be replaced with a keyframe sequence with a CSS variable as its property: FAIL[linux64-qr-opt] Keyframes can be replaced with a property-indexed keyframes specification with a CSS variable as the property: FAIL[linux64-qr-opt] Keyframes can be replaced with a two property (one shorthand and one of its shorthand components) two value property-indexed keyframes specification: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cad9765bc4b2 [wpt PR 18845] - [web-animations] Correctly handle parsing and serializing shorthands, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/fdc05ae1043b [wpt PR 18845] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/cad9765bc4b2
https://hg.mozilla.org/mozilla-central/rev/fdc05ae1043b

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.