1578853 - Pin Tab CFR widget does not respond to clicks

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[John Gruen [:jgruen]]

Attachment: cfr not working 2.gif

Nightly 71.0a1 on MacOS...this happened in a Gmail tab. See the attached gif for a demo.

Comment 1

[John Gruen [:jgruen]]

I have to errors in my console at around this time, but i don't think either is related:

BadContentError: "/Users/johngruen/Library/Caches/Firefox/Profiles/6lp7ckvr.default-nightly/settings/main/public-suffix-list/dafsa.bin content does not match server hash"
    BadContentError resource://services-settings/Attachments.jsm:29
    download resource://services-settings/Attachments.jsm:86
    init resource://gre/modules/netwerk-dns/PublicSuffixList.jsm:29
    promise callback*init resource://gre/modules/netwerk-dns/PublicSuffixList.jsm:27
    _scheduleArbitrarilyLateIdleTasks resource:///modules/BrowserGlue.jsm:2185
PublicSuffixList.jsm:34:29
    init resource://gre/modules/netwerk-dns/PublicSuffixList.jsm:34

and

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMWindowUtils.removeSheetUsingURIString]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 75"  data: no] 2 ExtensionCommon.jsm:75:12
    runSafeSyncWithoutClone resource://gre/modules/ExtensionCommon.jsm:75
    cleanup resource://gre/modules/ExtensionContent.jsm:402
    close resource://gre/modules/ExtensionContent.jsm:925
    destroyed resource://gre/modules/ExtensionContent.jsm:1010
    observe resource://gre/modules/ExtensionContent.jsm:1028

Comment 2

[Ed Lee :Mardak]

Bug 1571022 added a layout: "message_and_animation" type that needs to get into remote settings message.

Comment 3

[Ed Lee :Mardak]

Do you see a TypeError: content.addon is undefined CFRPageActions.jsm:541:9 message in red?

Comment 4

[Ed Lee :Mardak]

The prod remote settings was updated to add the layout property.

For QA, this is specifically Pin Tab as addon recommendations would have still worked. There's no "previous" version to verify broken as this was a server-side fix.

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

@Mardak, I can't seem to naturally trigger the Pin Tab and Addon recommendations anymore on Nightly or Release. I can trigger them via the asrouter page without issues and I can also naturally trigger the Save Login one. I've logged this behavior in bug 1580173. Was the property supposed to be added to all CFR Recommendations or only the Save Login one?

Comment 6

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Confirmed with :andreio on slack that the property was intended for all messages.
I have verified that the layout property has been added to all recommendations on Windows 10, macOS 10.14, and Arch Linux 4.14.3.