157890 - [FIX]too wide cells if table layout fixed used

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[tapio.markula]

>> http://www.nic.fi/~tapio1/Tests/NatureSiteMap.htm

>Looks like we make a bunch of cells 1px too wide when table-layout:fixed
is used, so that the last cell is not nearly wide enough.

YES - you have reached the main problem!

>You define the table to be 121px wide.  You define table cell widths
adding up to 119px.  There is no way to follow this CSS.  We have to
ignore either the 121 or the 119.  This is for the <table
class="allPages">; I have not bothered to investigate where else the
same sort of thing may have happened.

in table-layout:fixed the FIRST table row and width values for that is the MOST important factor. IF there is conflicts between the width of the entire table and total width calculating from the widths of individual cells, the total width of the entire table must be AT LEAST:

the sum of the width values for individual cells + possible padding, border & border-spacing values for table cells in the FIRST table row.

If the width of the entire table is BIGGER than the previous mentioned total width, the width of the entire table can be taken account. In this case Mozilla can interpret according to the '121px' BUT this is then the MAXIMUM value.
 
As you have noticed, Mozilla renders the width BIGGER than the maximum allowed width. Anyway Mozilla renders the width of the table cells too wide.

By the way I have tested giving for Mozilla Gecko fo the table element SMALLER width values as in the example, but it didn't help anything.

The error is apporiximately 1 pixel/ every cell as you have noticed! That's why  setting table.allPages {width:119px} doesn't solve anything.


Would you mind filing a bug on that?  Assign it to me, link to that
page.  I'll make sure it ends up in the right place.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Changing url to page that shows the problem.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: testcase showing some issues with table cell width calculations in fixed layout mode

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Comment 4

[Boris Zbarsky [:bzbarsky]]

bernd, would you review, please?

Comment 5

[karnaze (gone)]

Comment on attachment 91935 [details] [diff] [review]
Proposed fix

r=karnaze, if the change passes the regression tests.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yep.  It passes the regression tests.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 91935 [details] [diff] [review]
Proposed fix

sr=dbaron

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 91935 [details] [diff] [review]
Proposed fix

a=asa (on behalf of drivers) for checkin to 1.1

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 91935 [details] [diff] [review]
Proposed fix

a=asa (on behalf of drivers) for checkin to 1.1

Comment 10

[Boris Zbarsky [:bzbarsky]]

fix checked in on trunk.