1578920 - Local build failures due to bug 1507754

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

Various mach configure failures after bug 1507754.
They all seem to involve execution of hg commands failing.

Comment 1

[Rob Lemley [:rjl]]

Attachment: localbuildfixes.patch

I've tested various scenarios locally, and the try build looks okay so
far.

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9090526 [details] [diff] [review]
localbuildfixes.patch

Huh. I'm sure I r+'ed this earlier.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/64740b4f1270
Bug 1507754 follow-up: fix mach configure failures on local builds. r=darkrojan DONTBUILD

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9090526 [details] [diff] [review]
localbuildfixes.patch

[Approval Request Comment]
Regression caused by (bug #): 1507754
User impact if declined: Local builds are likely to fail
Testing completed (on c-c, etc.): This has been on central for a few weeks
Risk to taking this patch (and alternatives if risky): Low but important. It's a developer only affecting bug. There is a high failure rate without this fix.

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9090526 [details] [diff] [review]
localbuildfixes.patch

Jörg, I am really sorry, I grabbed the wrong ESR version for approval. Can this make it in to the next build? Kai is hitting this on his local builds.

[Approval Request Comment]
Regression caused by (bug #): 1507754
User impact if declined: Local builds are likely to fail
Testing completed (on c-c, etc.): This has been on central for a few weeks
Risk to taking this patch (and alternatives if risky): Low but important. It's a developer only affecting bug. There is a high failure rate without this fix.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9090526 [details] [diff] [review]
localbuildfixes.patch

Sure. You really don't need to fill in the details. I know what most bugs are about.

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68.2.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/045f4e476590665d33c03acedb71fd7438ec2499

Comment 8

[Kai Engert (:KaiE:)]

Thanks, that fixed my local build.