Closed Bug 1578966 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18865 - Switch InterpolableLength implementation from length array to expression

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18865 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18865
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

Switch InterpolableLength implementation from length array to expression

This patch changes the internal implementation of InterpolableLength
from CSSLengthArray to the following:

  • A CSSNumericLiteralValue to keep it simple when it's a simple value
  • A CSSMathExpressionNode to make it general when the underlying length
    involves calculation and math functions

In this way, we can interpolate when the length cannot be represented
as a CSSLengthArray (i.e., when comparison functions min/max are
involved).

Bug: 991672
Change-Id: Ib83fc0a07d0eb1d03a2465ac9df5282f963b935b

Reviewed-on: https://chromium-review.googlesource.com/1777025
WPT-Export-Revision: e67ffaf1e78f524d5ae2ad95f73cc0c88a18cc85

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
FAIL   : 1

New tests that have failures or other problems:
/css/css-values/minmax-length-percentage-interpolate.html: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ff49fa89cbb
[wpt PR 18865] - Switch InterpolableLength implementation from length array to expression, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa7439daa99a
[wpt PR 18865] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8ff49fa89cbb
https://hg.mozilla.org/mozilla-central/rev/fa7439daa99a

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.