Closed Bug 1578967 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18866 - [css-text-decor-4] Fix the expected serialization of text-decoration.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18866 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18866
Details from upstream follow.

Boris Chiou <boris.chiou@gmail.com> wrote:

[css-text-decor-4] Fix the expected serialization of text-decoration.

The serialization of text-decoration from gCS should have the similar
results as that of its specified values. text-decoration was longhand
before, so for backward-compatible, it's better to omit
text-decoration-color, text-decoration-style, and
text-decoration-thickness if they are initial values [1].

Note: text-decoration-thickness is added in [css-text-decor-4] [2].

[1] https://drafts.csswg.org/css-text-decor-3/#text-decoration-property
[2] https://drafts.csswg.org/css-text-decor-4/#text-decoration-width-property

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 3 tests and 62 subtests
OK     : 3
PASS   : 35[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt], 36[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
FAIL   : 26[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt], 27[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/css-text-decor/text-decoration-serialization.tentative.html
    text-decoration shorthand serialization: FAIL

New tests that have failures or other problems:
/css/css-text-decor/parsing/text-decoration-computed.html
    Property text-decoration value '10px' computes to 'rgb(0, 0, 255) 10px': FAIL
    Property text-decoration value 'auto' computes to 'rgb(0, 0, 255)': FAIL
    Property text-decoration value 'currentcolor' computes to 'rgb(0, 0, 255)': FAIL
    Property text-decoration value 'from-font' computes to 'rgb(0, 0, 255) from-font': FAIL
    Property text-decoration value 'line-through' computes to 'line-through rgb(0, 0, 255)': FAIL
    Property text-decoration value 'none' computes to 'rgb(0, 0, 255)': FAIL
    Property text-decoration value 'rgba(10, 20, 30, 0.4) dotted' computes to 'dotted rgba(10, 20, 30, 0.4)': FAIL
    Property text-decoration value 'solid' computes to 'rgb(0, 0, 255)': FAIL
    Property text-decoration value 'underline red from-font' computes to 'underline rgb(255, 0, 0) from-font': FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/040259895ffd
[wpt PR 18866] - [css-text-decor-4] Fix the expected serialization of text-decoration., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/539e2c6e8f85
[wpt PR 18866] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/040259895ffd
https://hg.mozilla.org/mozilla-central/rev/539e2c6e8f85

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.