1578969 - The server should format nested properties

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

The server currently formats top-level properties and ignores nested

I think this patch should fix that. The rationale is that I believe that only top-level objects are added to the persisted pools. This forces all objects we're watching to be added to a pool.

diff --git a/devtools/server/actors/object.js b/devtools/server/actors/object.js
index 7aa67b162ac0..4e17ed40cfcc 100644
--- a/devtools/server/actors/object.js
+++ b/devtools/server/actors/object.js
@@ -108,6 +108,7 @@ const proto = {
   },

   addWatchpoint(property, label, watchpointType) {
+    this.hooks.createValueGrip(this.rawValue())
     if (this._originalDescriptors.has(property)) {
       return;
     }

Other notes:

• look in actors/frame.js:form for where top level objects are added to a pool
• look in actors/thread.js:createValueGrip for the pool stuff

Comment 1

[Jason Laster [:jlast]]

This is now fixed