Closed Bug 1578992 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18868 - [webnfc] Impl "typedef DOMString NDEFRecordType"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18868 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18868
Details from upstream follow.

Leon Han <leon.han@intel.com> wrote:

[webnfc] Impl "typedef DOMString NDEFRecordType"

This CL switches the IDL type definition from
"enum NDEFRecordType { "empty", "text", "url", "json", "opaque" };"
to
"typedef DOMString NDEFRecordType" according to web-nfc spec.

This is in preparation for supporting 'smart-poster' and external type
records in the future, which was added in
https://github.com/w3c/web-nfc/pull/278.

BUG=520391

Change-Id: I45ec31afb3841cc5b12c954ffc2821da357fef04

Reviewed-on: https://chromium-review.googlesource.com/1781510
WPT-Export-Revision: 0e53af7dab722a1e157a61a980b38f0a294b945f

PR 18868 applied with additional changes from upstream: 685003d701e3c4154227758c65259c56662aa23d
Ran 1 tests and 7 subtests
OK     : 1
FAIL   : 7

New tests that have failures or other problems:
/web-nfc/NDEFRecord_constructor.https.html
    NDEFRecord constructor with record type string being treated as case sensitive: FAIL
    NDEFRecord constructor with text record type: FAIL
    NDEFRecord constructor with url record type: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e393d8834a4d
[wpt PR 18868] - [webnfc] Impl "typedef DOMString NDEFRecordType", a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/4837d3ce3fc9
[wpt PR 18868] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e393d8834a4d
https://hg.mozilla.org/mozilla-central/rev/4837d3ce3fc9

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.