Closed Bug 1578993 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 18869 - Revert "[webnfc] Refactor/Refine impl for "Creating Web NFC message" algorithm"

Categories

(Core :: DOM: Device Interfaces, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18869 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18869
Details from upstream follow.

Findit <findit-for-me@appspot.gserviceaccount.com> wrote:

Revert "[webnfc] Refactor/Refine impl for "Creating Web NFC message" algorithm"

This reverts commit 581b273e3743fcbd168775edfeebae8b092fc706.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 693539 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU4MWIyNzNlMzc0M2ZjYmQxNjg3NzVlZGZlZWJhZThiMDkyZmM3MDYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-archive-rel/7906

Sample Failed Step: compile

Original change's description:

[webnfc] Refactor/Refine impl for "Creating Web NFC message" algorithm

This CL implements strictly the "Creating Web NFC message" algorithm
described at http://w3c.github.io/web-nfc/#creating-web-nfc-message.

Changes the Web IDL definition for NDEFRecordData from
"typedef (DOMString or unrestricted double or ArrayBuffer or Dictionary) NDEFRecordData;"
to
"typedef any NDEFRecordData;"

Adds verification of NDEFRecordInit when creating NDEFRecord, i.e. makes
NDEFRecord ctor throw exceptions in case of invalid NDEFRecordInit.
Also, the same thing for NDEFMessage and NFCReadingEvent.

Changes code flow for Step 10.9 of "9.10.1 The push() method" described
at https://w3c.github.io/web-nfc/#the-push-method.
"
Let output be the notation for the NDEF message to be created by UA, as
the result of passing message to create Web NFC message. If this throws
an exception, reject p with that exception and abort these steps.
"
Previously,
NDEFMessageSource (NDEFMessageInit) -Validity check->
-Mojo TypeConverter-> Mojom NDEFMessagePtr
Now,
Remove "Validity check" and "Mojo TypeConverter" mentioned above,
instead, we reuse the process of creating NDEFMessage from
NDEFMessageSource (NDEFMessageInit), then the next step converting
NDEFMessage to Mojom NDEFMessagePtr is quite an easy job.

BUG=520391

Change-Id: I628981e556f89ffdd0f883da0cfa99b20a6f8300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767719
Commit-Queue: Leon Han \<leon.han@intel.com>
Reviewed-by: Daniel Cheng \<dcheng@chromium.org>
Reviewed-by: Reilly Grant \<reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik \<rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#693539}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=520391

Change-Id: I29fbd5f35999f41bfd1bc776c3c375bf3e6245f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787234
Cr-Commit-Position: refs/heads/master@{#693586}

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core
Ran 2 tests and 27 subtests
OK     : 2
FAIL   : 27
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9649fed08226
[wpt PR 18869] - Revert "[webnfc] Refactor/Refine impl for "Creating Web NFC message" algorithm", a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.