Closed Bug 1579003 Opened 9 months ago Closed 9 months ago

Implement megabar growing and shrinking animation

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 71
Iteration:
71.1 - Sept 2 - 15
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- disabled
firefox72 --- disabled
firefox73 --- disabled
firefox74 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

verdi says we should use the photon animation curve and 250ms duration.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 71.1 - Sept 2 - 15
Depends on: 1577472
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48e712ae6367
Implement megabar growing and shrinking animation. r=harry

FWIW, left, width and padding transitions are not be able to run on the compositor, which means it consumes the main-thread to update styles on every tick. Also it causes reflow.

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)

FWIW, left, width and padding transitions are not be able to run on the compositor, which means it consumes the main-thread to update styles on every tick. Also it causes reflow.

It's a positioned element so the reflow should be limited to that? Happy to look into other ways to implement this animation though, if you have suggestions.

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

(In reply to Dão Gottwald [::dao] from comment #4)

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)

FWIW, left, width and padding transitions are not be able to run on the compositor, which means it consumes the main-thread to update styles on every tick. Also it causes reflow.

It's a positioned element so the reflow should be limited to that? Happy to look into other ways to implement this animation though, if you have suggestions.

If we don't expect siblings of the transitioning element is not moved by the transition, left and padding transition can be replaced by transform. I have no idea about the width transition. Unfortunately transform transition with geometric change property transition, e.g. width, left, etc. can't be run on the compositor.

Regressions: 1586204

I can confirm the animation is implemented. I verified using Fx 74.0a1(2020-02-04) on Windows 10 x64, Ubuntu 18.04 and macOS 10.15.
Updating the flags accordingly.

You need to log in before you can comment on or make changes to this bug.