Closed Bug 1579020 Opened 4 years ago Closed 3 years ago

consider removing the calendar wcap support

Categories

(Calendar :: Provider: WCAP, task)

Product:
Calendar
Component:
Provider: WCAP
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 73.0

People

(Reporter: mkmelin, Assigned: Fallen)

Details

Attachments

(1 file, 1 obsolete file)

bug-1579020-remove-wcap-provider.diff
184.89 KB, patch
Details | Diff | Splinter Review

https://searchfox.org/comm-central/source/calendar/providers/wcap

WCAP is an odd standard - https://en.wikipedia.org/wiki/Web_Calendar_Access_Protocol

I suppose, it was only the Sun servers that ever implemented it. It's successor Oracle Communications Messaging Server has had CalDAV support for almost a decade, so if there is any WCAP usage left, people have a good upgrade path they can use.

http://www.oracle.com/us/industries/communications/communications-calendar-server-ds-071728.pdf

It would seem best to bury this, and focus on improved CalDAV support instead.

There is only 5 bugs touched in the last 5 years in this bugzilla component...!

I was pretty sure I filed a bug to remove this. I believe I checked with a few WCAP folks via email a long while ago and there was no interest in maintaining it as an add-on. I've put them on CC just to make sure I didn't forget about a reply.

Based on Bug 1582429 / Bug 1582746 there are still WCAP users with Thunderbird 68.

Attached patch Changes minus removals - v1 (obsolete) — — Splinter Review

I'll see if I can extract this into a repository and make it an add-on as well, but I can't commit to maintaining it. If someone wants to pick it up I'm happy to add ownership to that repo.

Again just the changes minus removals. I deleted:

calendar/locales/en-US/chrome/calendar/providers/wcap/wcap.properties
calendar/providers/wcap/

Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #9097018 - Flags: review?(geoff)

What do we know about the URLs? Is it possible to autodetect CalDAV support and move to that, for existing users? (Maybe after bug 306495?)

I'm sure it would be possible in some form, though I currently don't feel it is worth the migration effort. This is a provider last actively developed about 10 years ago and users of it will be rare. If we get support questions, we can point them to the github repo I set up at https://github.com/kewisch/wcap-provider .

Attachment #9097018 - Flags: review?(geoff) → review+

Was there a try run? checkin-needed?

After this, I assume the calendar subscription dialog is also dead, and can be removed. https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/calendar/lightning/content/messenger-overlay-sidebar.xul#142

For the checkin, see bug 1584614 comment #3.

(In reply to Magnus Melin [:mkmelin] from comment #7)

After this, I assume the calendar subscription dialog is also dead, and can be removed. https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/calendar/lightning/content/messenger-overlay-sidebar.xul#142

The feature was originally written for WCAP, but it could be useful for CalDAV as well. I believe the RFC allows for searching of calendars, and I believe Cyrus also has a draft for more advanced calendar search. If we want to revamp this feature with completely new UI based on HTML I'd be ok removing it for now though.

So can we finish this off?

Let's consider the subscription dialog in a followup. I'd be happy if someone could do a try run for me, but I think this is essentially ready to go.

Full removal patch which was on try. Seems try is happy so I'll go ahead and land it later then.

Attachment #9097018 - Attachment is obsolete: true
Keywords: checkin-needed-tb

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/cf982e0a8b1b
Remove WCAP provider. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Hmm, we have no 73 milestone yet. Philipp, is it you who's creating those?

Flags: needinfo?(philipp)

Make it 72 in the meantime.

Target Milestone: --- → 72
Flags: needinfo?(philipp)
Target Milestone: 72 → 73
You need to log in before you can comment on or make changes to this bug.