Closed Bug 1579025 Opened 5 years ago Closed 5 years ago

schedulegc testing function does two unrelated things and is only available where JS_GC_ZEAL is defined

Categories

(Core :: JavaScript: GC, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

This function deals with scheduling a GC after a certain number of iterations, and selecting which zones will be collected in a zone GC. Because of the former operation it's only present when GC zeal is built, but the latter operation is still useful to have in other builds (e.g. opt builds).

We should split this into two separate functions.

This splits schedulegc() into schedulegc() and schedulezone() and adds an option parameter to gcstate() to report the GC state of a zone. I moved gcstate() so that it is not only present in zeal builds and updated test uses of schedulegc() as appropriate.

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11d7643d276d
Split schedulegc testing function into two separate functions r=sfink
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee: nobody → jcoppeard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: