nsFrameLoader::GetBrowsingContext forces initialization
Categories
(Core :: DOM: Navigation, task, P3)
Tracking
()
| Fission Milestone | M5 |
People
(Reporter: nika, Unassigned)
Details
Currently, when calling nsFrameLoader::GetBrowsingContext, logic to force initialization of the remote browser is run, despite the BrowsingContext having already been created as mBrowsingContext. This is likely unnecessary.
A quick attempt to remove it as part of other changes appears to have caused test breakage, so this initialization appears to be load-bearing in some way or another. I have not spent much time trying to figure out why.
|
Reporter | |
Updated•6 years ago
|
|
||
Comment 1•6 years ago
|
||
The problem is that mBrowsingContext and GetBrowsingContext() are only sometimes the same thing. Which is a pretty big footgun that I've been meaning to fix.
|
||
Comment 2•6 years ago
|
||
Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.
This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:
0ee3c76a-bc79-4eb2-8d12-05dc0b68e732
|
|
||
Comment 3•6 years ago
|
||
Assigning to kmag because he has a patch up for review on a related bug.
Tracking for Fission dogfooding (M5)
|
|
||
Comment 4•6 years ago
|
||
Nika filed this bug, but she now says it's not worth fixing and recommends resolving WONTFIX.
Description
•