Closed Bug 1579126 Opened 3 months ago Closed 3 months ago

Make the "Allowed" section heading in the protections panel a heading for screen readers as well

Categories

(Firefox :: Protections UI, enhancement, P1)

Desktop
All
enhancement

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: MarcoZ, Assigned: MarcoZ)

Details

(Keywords: access, Whiteboard: [privacy-panel][skyline][access-p2])

Attachments

(1 file)

When I implemented headings for the other section headers, I overlooked the one for allowed trackers.

Type: defect → enhancement
Priority: -- → P1
Whiteboard: [skyline] → [privacy-panel][skyline]
Pushed by mzehe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3178fdd28f80
Make the Allowed section heading in the protections panel a heading for screen readers as well, r=nhnt11
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9090752 [details]
Bug 1579126 - Make the Allowed section heading in the protections panel a heading for screen readers as well, r=johannh

Beta/Release Uplift Approval Request

  • User impact if declined: Users cannot find the Allowed Trackers section as easily if using a screen reader. Compared to the other headings introduced, this feels unpolished.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None.
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just adds a role of heading and heading level to an element without changing semantics or styling. These attributes are purely for screen reader exposure.
  • String changes made/needed: None.
Attachment #9090752 - Flags: approval-mozilla-beta?

Comment on attachment 9090752 [details]
Bug 1579126 - Make the Allowed section heading in the protections panel a heading for screen readers as well, r=johannh

Simple fix for a11y in skyline feature, OK for beta uplift for beta 6

Attachment #9090752 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [privacy-panel][skyline] → [privacy-panel][skyline][access-p2]
You need to log in before you can comment on or make changes to this bug.