Closed Bug 1579180 Opened 5 months ago Closed 4 months ago

Adjust the logged-out-view of the FxA button to match the spec

Categories

(Firefox :: about:logins, defect, P2, minor)

70 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox70 --- verified
firefox71 --- verified

People

(Reporter: ddurst, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(1 file)

The <p> should be adjusted down from 20ch so that the text breaks after "Get your passwords".

In the <button>, the padding around "Sign in to Sync" should be increased to match the spec; the font size should also be adjusted down to match the spec.

Whiteboard: [passwords:management] [skyline]

During yesterday's team discussion, we decided to remove the requirement that there is a line break following "Get your passwords". This bug now only exists to increase the width of the "Sign in to Sync" button and lower the font-size.

Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90cd886fc3ae
Adjust the logged-out-view of the FxA button to match the spec. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Comment on attachment 9093682 [details]
Bug 1579180 - Adjust the logged-out-view of the FxA button to match the spec. r?sfoster

Polish issue for Skyline feature, part of batch uplift for beta 9.

Attachment #9093682 - Flags: approval-mozilla-beta+

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20190923215658) and on the Firefox Beta 70.0b9 (Build ID: 20190923154733) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 18.04 x64.

  • The width of the “Sign in to Sync” button is increased and the font-size is lower.
  • The “Sign in to Sync” and “email address + avatar” are properly displayed.
Status: RESOLVED → VERIFIED
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla71 → Firefox 71
Version: unspecified → 70 Branch
You need to log in before you can comment on or make changes to this bug.