1579196 - Data Review for New Fennec Core Ping Fields

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Metrics, task, P1)

Description

[Frank Bertsch [:frank]]

Attachment: fennec_core_updates_data_review.txt

In order to support the Fennec -> Fenix migration, the Product team would like to understand which features in Fennec people are using, so they can be best supported on Fenix.

We're tracking that work here: https://docs.google.com/document/d/1BCjlx8Rl5Sc_sQvbxr1A2w9k4GKT4oId9LfdETL8la4/edit

Attached is the data review.

Comment 1

[Chenxia Liu [:liuche]]

Comment on attachment 9090801 [details]
fennec_core_updates_data_review.txt

Tentative data-review, pending questions, and pending the actual patch. The actual patch will need documentation when the probes actually land, in an update to https://searchfox.org/mozilla-central/source/mobile/android/docs/uitelemetry.rst

A few questions:
- Not approving addon names collection. I will double check and comment back.
- Is Fennec telemetry actually default on for release populations? Is this through Telemetry or FHR?
- Will we push a change to stop collecting data for Fennec users, before we replace Fennec? This would affect users who are on API levels that aren't going to be replaced.

# Data Review Form (to be filled by Data Stewards)

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

TODO - please flag me again when the patch is ready. It will need updates to https://searchfox.org/mozilla-central/source/mobile/android/docs/uitelemetry.rst

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, data controls in Fennec settings

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, until Fennec sunset in June 2020

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2 for most data types
I have some concerns about Addon names, but raising that separately. 

5) Is the data collection request for default-on or default-off?

Default on? I'm not sure what the Fennec data settings are, but I assumed it was actually off for release.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No, for the non-addons ones, are counts or booleans

7) Is the data collection covered by the existing Firefox privacy notice?

Yes for all the Type 2 data

8) Does there need to be a check-in in the future to determine whether to renew the data? 

Will collect through Q2 2020, also asking about EOL Fennec

9) Does the data collection use a third-party collection tool? 

No, through FHR and/or UI Telemetry.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment #9090801 [details] - Flags: data-review+

Frank, what are the next steps for this bug now that Chenxia granted data-review+?

Setting firefox68=affected status flag to move this bug from Fennec's "Triaged bugs to be confirmed by QA" queue to the "Confirmed bugs to be fixed" queue.

Comment 3

[Frank Bertsch [:frank]]

Hey Chris, next steps are the pipeline implementation and the client-side work. I'm taking the former in Bug 1584194, and I believe Stefan is handling the tracking of the client-side in Bug 1584188. ni Stefan here just to confirm that this is covered.

Comment 4

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

From the data review request:

Settings - Homepage Customization (UNCLEAR)

Can you expand on this?

The fields that landed in bug 1586302 that I don't see discussed here are:

topsites_enabled
pocket_enabled
recent_bookmarks_enabled
visited_enabled
bookmarks_enabled
history_enabled

These look like boolean fields reflecting product interactions, so therefore cat 2 data; does that sound right?

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Thanks Tim for keeping track of all this tickets!
Bug 1583525 also wanted to add a new field to the new "fennec" object in the core field.
I also added there the documentation for the entire new "fennec" telemetry and because now all the work is finished I asked @liuche there for a new data review.

Comment 6

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Are you still able to update the core ping docs to reflect these new probes?

Comment 7

[Petru-Mugurel Lingurar [:petru]]

(In reply to Tim Smith 👨‍🔬 [:tdsmith] from comment #6)

Are you still able to update the core ping docs to reflect these new probes?

I updated the docs in bug 1579196.
Are there any more changes needed?

Comment 8

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Ah, looks like you mean bug 1583525; I'll follow up there. Thanks!