1579213 - Remove unused fields from nsFrameLoader::ChangeRemoteness API

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P2)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1579213 - Remove unused fields from ChangeRemoteness API,

This patch changes a few things about how nsFrameLoader is created, specifically
around the ChangeRemoteness API.

1. The private 'nsFrameLoader::nsFrameLoader' constructor has been simplified to
   only have one overload, shared by the different ::Create static methods.

2. The creation static method used by ChangeRemoteness has changed name to
   ::Recreate, as the signature is becoming more like the old method.

3. The mNetworkCreated bit is preserved when doing a ChangeRemoteness, as a
   remoteness change shouldn't be affecting that property.

4. Unused fields are removed from the ChangeRemoteness API.

5. The remoteType attribute is now mandatory in the ChangeRemoteness API,
   which simplifies the logic and makes it harder to accidentally misuse.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b362210b4e5
Remove unused fields from ChangeRemoteness API, r=farre

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9b362210b4e5