Closed Bug 1579218 Opened 3 months ago Closed 3 months ago

JSWindowActorProtocol::Matches() doesn't properly handle webIsolated remote types

Categories

(Core :: DOM: Content Processes, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla71
Fission Milestone M4
Tracking Status
firefox71 --- fixed

People

(Reporter: mccr8, Assigned: jdai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It does this:
if (!mRemoteTypes.IsEmpty() && !mRemoteTypes.Contains(aRemoteType)) {
but aRemoteType for a Fission process will be something like webIsolated=www.cnn.com.

I'm not sure what the right behavior is. Maybe this could trim aRemoteType to "web" if it starts with "web"? There's a test that uses "web" in browser_getActor_filter.js.

Or maybe we want to make it "webIsolated"? That's what the existing RemoteTypePrefix() does, but I think that is inconsistent with the idea that everything that starts with "web" is in some ways equivalent.

Blocks: 1576995

Also, the description says "Optional list of regular expressions for remoteTypes", but it looks to just be doing an exact string match against each member of the set.

(In reply to Andrew McCreight [:mccr8] from comment #1)

Also, the description says "Optional list of regular expressions for remoteTypes", but it looks to just be doing an exact string match against each member of the set.

Thank you for reporting this bug. We have two solutions for this issue. One is to use prefix to match remoteTypes, another is to use regular expressions to match remoteTypes. Per discussion with Nika, we should use prefix to match remoteTypes, because it's how we do in E10SUtils.jsm right now.

Assignee: nobody → jdai
Status: NEW → ASSIGNED
Fission Milestone: --- → M4
Priority: -- → P2
Pushed by jdai@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59ec87990119
Fix JSWindowActorProtocol::Matches() doesn't properly handle webIsolated remote types; r=nika
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.