1579218 - JSWindowActorProtocol::Matches() doesn't properly handle webIsolated remote types

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P2)

Description

[Andrew McCreight [:mccr8]]

It does this:
if (!mRemoteTypes.IsEmpty() && !mRemoteTypes.Contains(aRemoteType)) {
but aRemoteType for a Fission process will be something like webIsolated=www.cnn.com.

I'm not sure what the right behavior is. Maybe this could trim aRemoteType to "web" if it starts with "web"? There's a test that uses "web" in browser_getActor_filter.js.

Or maybe we want to make it "webIsolated"? That's what the existing RemoteTypePrefix() does, but I think that is inconsistent with the idea that everything that starts with "web" is in some ways equivalent.

Comment 1

[Andrew McCreight [:mccr8]]

Also, the description says "Optional list of regular expressions for remoteTypes", but it looks to just be doing an exact string match against each member of the set.

Comment 2

[John Dai[:jdai]]

(In reply to Andrew McCreight [:mccr8] from comment #1)

Also, the description says "Optional list of regular expressions for remoteTypes", but it looks to just be doing an exact string match against each member of the set.

Thank you for reporting this bug. We have two solutions for this issue. One is to use prefix to match remoteTypes, another is to use regular expressions to match remoteTypes. Per discussion with Nika, we should use prefix to match remoteTypes, because it's how we do in E10SUtils.jsm right now.

Comment 3

[John Dai[:jdai]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=766594be4c29ac56a867522f37219c7ce368898f

Comment 4

[John Dai[:jdai]]

Attachment: Bug 1579218 - Fix JSWindowActorProtocol::Matches() doesn't properly handle webIsolated remote types;

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59ec87990119
Fix JSWindowActorProtocol::Matches() doesn't properly handle webIsolated remote types; r=nika

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/59ec87990119