Closed Bug 1579222 Opened 3 months ago Closed 2 months ago

Fennec Crash in [@ JSAutoRealm::JSAutoRealm]

Categories

(Core :: XPConnect, defect, P1, critical)

68 Branch
Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 70+ fixed
firefox69 --- wontfix
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: marcia, Assigned: kmag)

Details

(Keywords: crash, regression, topcrash)

Crash Data

Attachments

(1 file)

It appears we have a spike in this signature in the Fennec 68.1 release: https://crash-stats.mozilla.org/signature/?signature=JSAutoRealm%3A%3AJSAutoRealm#summary. No particular trend in the URLs. APIs range from 16-28. Top crashing devices so far are two HUAWEI CLT-L29 and WAS-LX1A, followed by the Samsung Galaxy S5 mini.

Spinning this out of Bug 1535346 as requested.

Assignee: nobody → kmaglione+bmo
Component: JavaScript Engine → XPConnect

Top crashing ARM graphics adapters:

Mali-T830
Mali-400 MP
Mali-G72
Mali-G71

68 release has accumulated almost 12K crashes in this signature.

Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1e934531dc8e
Don't discard scripts before they've been encoded for the cache write. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Please nominate this for Beta and ESR68 approval when you get a chance.

Flags: needinfo?(kmaglione+bmo)

Comment on attachment 9093425 [details]
Bug 1579222: Don't discard scripts before they've been encoded for the cache write. r=erahm

Beta/Release Uplift Approval Request

  • User impact if declined: Fixes crashes.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a trivial change which simply moves back the point where we start throwing away script data from the script preloader cache. The only plausible regression would be a relatively trivial increase in memory usage if some part of the logic was wrong.
  • String changes made/needed:

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: It's a relatively frequent crasher on Fennec with a trivial fix.
  • User impact if declined: Fixes crashes.
  • Fix Landed on Version: 71
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a trivial change which simply moves back the point where we start throwing away script data from the script preloader cache. The only plausible regression would be a relatively trivial increase in memory usage if some part of the logic was wrong.
  • String or UUID changes made by this patch:
Flags: needinfo?(kmaglione+bmo)
Attachment #9093425 - Flags: approval-mozilla-esr68?
Attachment #9093425 - Flags: approval-mozilla-beta?

Comment on attachment 9093425 [details]
Bug 1579222: Don't discard scripts before they've been encoded for the cache write. r=erahm

Fixes a Fennec top crash. Approved for 70.0b9 and Fennec 68.2b4.

Attachment #9093425 - Flags: approval-mozilla-esr68?
Attachment #9093425 - Flags: approval-mozilla-esr68+
Attachment #9093425 - Flags: approval-mozilla-beta?
Attachment #9093425 - Flags: approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.