1579251 - Support modal less about:welcome page

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Show a modal less about:welcome page that combines interrupts and triplet on a single page similar to old about:welcome experience

Needed to support PRD hypothesis 3 around Modal blindness: https://docs.google.com/document/d/10TbPuTNJnEk0J_4sdWjT2WFpGhRlF6iQy61tseWYwww/edit#heading=h.y7gzj56ujyk5

Comment 1

[Punam Dahiya [:pdahiya]]

NI Aaron to help point to in-vision design to support this requirement.

Comment 2

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Punam, you asked for this bug to be tracked by release management without saying why, could you provide more details please? Thanks

Comment 4

[Punam Dahiya [:pdahiya]]

(In reply to Pascal Chevrel:pascalc from comment #3)

Punam, you asked for this bug to be tracked by release management without saying why, could you provide more details please? Thanks

Sorry just meant to update status affected for 71, removed tracking flag which was set by mistake. Thanks!

Comment 5

[Punam Dahiya [:pdahiya]]

Design doc:
https://mozilla.invisionapp.com/share/Z2TU7RVFBN4#/screens/384813540_about-welcome_Variants_Alt

Comment 6

[Punam Dahiya [:pdahiya]]

Attachment: data-review-request.txt

Comment 7

[Punam Dahiya [:pdahiya]]

Comment on attachment 9099974 [details]
data-review-request.txt

@chutten this add a new onboarding user event for about:welcome full page experiment. Please provide data review. Thanks!

Added event is documented below:
https://github.com/mozilla/activity-stream/pull/5307/files#diff-f9d20d6688eef2754298456e5d5b836bR449

Comment 8

[Chris H-C :chutten]

Comment on attachment 9099974 [details]
data-review-request.txt

Load balance to Megan.

Comment 9

[Punam Dahiya [:pdahiya]]

Hi Megan , will you able to look into this data review today. Please let me know if you have any questions. Thanks

Comment 10

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1579251 - Full page about:welcome variant

Comment 11

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5349

Comment 12

[Chris H-C :chutten]

Comment on attachment 9099974 [details]
data-review-request.txt


DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is documented in [Activity Stream's data documentation](https://github.com/punamdahiya/activity-stream/blob/master/docs/v2-system-addon/data_events.md).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Nan Jiang is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 13

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9d2586266fcd

Comment 14

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (71.0a1 Build ID - 20191014095234) installed, on Windows 10 x64, Arch Linux and Mac 10.14.6. Now, I can confirm that "full_page_d-supercharge" and "full_page_e-supercharge" variants are respecting the design specs from here.