Bring metadata treatment into spec alignment
Categories
(Firefox :: about:logins, defect, P3, minor)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox69 | --- | disabled |
firefox70 | --- | verified |
firefox71 | --- | verified |
People
(Reporter: ddurst, Assigned: jaws)
References
Details
(Whiteboard: [passwords:management] [skyline])
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
- The metadata (.meta-info) text color should be #737373
- The margins should be: margin-bottom: 8px and margin-top: 0
- The font-weight should be reduced
Reporter | ||
Updated•3 months ago
|
Updated•3 months ago
|
Assignee | ||
Updated•3 months ago
|
Assignee | ||
Comment 1•3 months ago
|
||
I confirmed using the built-in accessibility tools that there is enough contrast in regular and dark mode.
Comment 2•3 months ago
|
||
(In reply to David Durst [:ddurst] from comment #0)
- The metadata (.meta-info) text color should be #737373
- The margins should be: margin-bottom: 8px and margin-top: 0
- The font-weight should be reduced
In the design mockup, I don't see a visual difference between the field labels ("Username", "Password" etc.) and the meta-data. Is there a different reference for these color values? We were using --in-content-deemphasized-text
which in a regular non-dark mode is --grey-60, which is #4a4a4f - a little darker than #737373 and more legible to my eyes at least? So ISTM either we need to use #737373 in both places or --grey-60 (or some compromise.) Or, update the mockup.
Assignee | ||
Comment 3•3 months ago
|
||
This bug came from a ux review. Indeed the spec needs updating. I confirmed there is enough contrast and am still using the deemphasized text color in dark mode.
Reporter | ||
Comment 4•3 months ago
|
||
That's a good question -- NI to Ryan on this. Note #c2, where the labels treatment is the same as the metadata treatment.
In the design mockup, I don't see a visual difference between the field labels ("Username", "Password" etc.) and the meta-data.
This is true, and both the labels, as well as the metadata, should be the same values...
Per the spec, I have them at #737373, which is lighter than the current implementation.
Should we have a separate issue to address the Website Address/Username/Password labels, or can that also be addressed in this issue?
Design Spec referenced: https://zpl.io/VO1nRGk
Reporter | ||
Comment 7•3 months ago
•
|
||
Probably addressed in this issue, but the disconnect between --in-content-deemphasized-text
makes this not as straightforward.
I guess if we want this lighter, we'd want to override that semantic class so we don't affect other uses.
Assignee | ||
Comment 8•3 months ago
|
||
(In reply to rgaddis from comment #5)
Should we have a separate issue to address the Website Address/Username/Password labels, or can that also be addressed in this issue?
I have updated the Website Address/Username/Password labels in this patch.
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/035571ecb663 Bring metadata treatment into spec alignment. r=sfoster
Comment 10•3 months ago
|
||
Comment 11•3 months ago
|
||
bugherder |
Assignee | ||
Updated•3 months ago
|
Assignee | ||
Updated•3 months ago
|
Comment 12•3 months ago
|
||
Comment on attachment 9092798 [details]
Bug 1579252 - Bring metadata treatment into spec alignment. r?sfoster
Skyline issue, let's bring this to beta 9. (Part of batch uplift requested by MattN)
Comment 13•3 months ago
|
||
bugherderuplift |
Comment 15•2 months ago
|
||
I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20190923215658) and on the Firefox Beta 70.0b9 (Build ID: 20190923154733) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 18.04 x64.
- The metadata text color is #737373.
- The margins are: margin bottom: 8px and margin-top: 0.
- The font-weight is 300.
- The login-footer margin-top is 20 px.
- Also, all changes are visible.
Updated•2 months ago
|
Description
•