1579269 - Ensure that "InRDMPane" property is set on the window's document when RDM is active

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, task, P1)

Description

[Micah [:mtigley] (she/her)]

The existing embedded RDM protoype does not set the InRDMPane property on the document when RDM is enabled. Currently, this is set in https://searchfox.org/mozilla-central/source/devtools/client/responsive/browser/content.js#187 which is no longer being called since removing usage of <mozbrowser>.

This property is used in multiple places on the platform side to simulate various features such as:

• overlay scrollbars
• device size
• resolution zooming

Comment 1

[Micah [:mtigley] (she/her)]

Adding an additional actor method on the emulation front called toggleDocumentInRDMPane and calling this in the Responsive UI manager when opened or closed is likely what we'll need to do for this.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1579269 Part 1: Make the document inRDMPane property set via a new emulation actor method.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1579269 Part 2: Remove the frame script method of setting inRDMPane property.

Depends on D51020

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1579269 Part 2: Add a test of the inRDMPane property.

Depends on D51021

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84560702e4bf
Part 1: Make the document inRDMPane property set via a new emulation actor method. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/393d01dc0de0
Part 2: Add a test of the inRDMPane property. r=mtigley

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/84560702e4bf
https://hg.mozilla.org/mozilla-central/rev/393d01dc0de0