1579315 - Test import-export.js

Status: RESOLVED FIXED

(Calendar :: Import and Export, task)

Description

[Geoff Lankow (:darktrojan)]

There should be tests for importing and exporting items, and there aren't.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1579315-import-test-1.diff

Here's a simple test for importing items. Most of the change to import-export.js is adding indentation, because I've made it return a Promise.

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9093470 [details] [diff] [review]
1579315-import-test-1.diff

Review of attachment 9093470 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray for more test coverage!  And more async!  LGTM.  One optional "while we're here" question/suggestion.

I ran the test using:
$ ../mach mochitest calendar/test/browser/browser_import.js
and it passed.  When I changed the assertion about the expected results from 4 to 3, the test failed as expected.

::: calendar/base/content/import-export.js
@@ +53,4 @@
>      }
>  
> +    picker.open(async rv => {
> +      if (rv != Ci.nsIFilePicker.returnOK || !picker.file || !picker.file.path) {

What is rv?  If you know, can we give it a less obscure name while we're here?

Comment 3

[Geoff Lankow (:darktrojan)]

rv is shorthand for return value. It's used all over the C++ code, although in JS it is rare.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/315a09d57f1b
Add a test of importing events; r=pmorris