1579360 - XPCWrappedNative.cpp: warning about null in JS_sprintf_append

Status: UNCONFIRMED

(Core :: XPConnect, task, P5)

Description

[Andreas Baumann]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

Compiled with gcc 9.1.0 on Archlinux and Archlinux32.

Actual results:

/build/seamonkey/src/seamonkey-2.49.4/mozilla/js/xpconnect/src/XPCWrappedNative.cpp:
2221:41: error: â directive argument is null [-Werror=format-overflow=]
2221 | name = JS_sprintf_append(name, fmt,
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~
2222 | array[i]->GetNameString());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~

Expected results:

Fixed with the following patch:

https://git.archlinux32.org/archlinux32/packages/src/branch/master/community/seamonkey/seamonkey-2.49.4-string-fmt.patch

Comment 1

[Frank-Rainer Grahl (:frg)]

gcc 9 is not a supported compiler for 2.49 and will probably result in a broken and/or crashy build. This is also mozilla Gecko code.

In mozilla-central it seems to be the following line is it:
name =
JS_sprintf_append(std::move(name), fmt, array[i]->GetNameString());

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:peterv, could you have a look please?

For more information, please visit auto_nag documentation.