1579366 - Console completion text isn't updated when autocomplete is disabled and popup isn't displayed

Status: VERIFIED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to about:config and turn off devtools.webconsole.input.autocomplete
2. Open the console
3. Type deb
4. Hit Ctrl+Space to display the completion text (should be ugger)
5. type u
6. Hit Tab

Expected results

The input get completed to debugger

Actual results

The input get completed to debuugger

---

This is because the completion text wasn't updated

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1579366 - Update completion text when autocomplete is disabled and popup isn't opened. r=Honza.

If the user triggered a force autocomplete (with Ctrl + Space)
that would result in having only the completion text, writing another
letter wouldn't update the completion text, that could then lead
into having an erroneous expression in the input.
This patch fixes this issue and add a test case to make sure we
don't regress this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ea036a387ec
Update completion text when autocomplete is disabled and popup isn't opened. r=Honza.

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2ea036a387ec

Comment 4

[Cristian Fogel [:cfogel]]

Fix confirmed with 71.0b5 on Windows 10, macOS 10.13, Ubuntu 18.04.