1579408 - Media capabilities code in aboutSupport.js does strange path manipulation

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[:Gijs (he/him)]

https://searchfox.org/mozilla-central/rev/2c0a60b5b065ae0fdfcfae168141e82b834fb2d4/toolkit/content/aboutSupport.js#875

This is not how you do path manipulation in a platform-agnostic way.

Use file.append() and then get the path.

Also, I hate to be a stickler about rules, but this patch should have had review from a relevant toolkit/firefox peer - they would probably have flagged this up.

Comment 1

[Alex Chronopoulos [:achronop]]

Thanks for the report I will fix it. I missed completely those rule do you have a link to them?

Comment 2

[:Gijs (he/him)]

(In reply to Alex Chronopoulos [:achronop] from comment #1)

Thanks for the report I will fix it. I missed completely those rule do you have a link to them?

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Code_Review_FAQ

https://wiki.mozilla.org/Modules/All#Toolkit

(Mossop is in the process of updating the Firefox/Toolkit modules to provide better guidance about who can review what, as well as doing some housekeeping in the list of active peers.)

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1579408 - Fix path manipulation in about support. r?gijs

Use file.append() to create the desired path in a platform agnostic way.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a5a3aef7880
Fix path manipulation in about support. r=Gijs

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7a5a3aef7880