Closed Bug 1579460 Opened 5 years ago Closed 5 years ago

No focus outline on in-content checkboxes when tabbing to them (e.g. warning in about:config, "show subsession data" in about:telemetry, etc.)

Categories

(Toolkit :: Themes, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- disabled
firefox69 --- disabled
firefox70 --- disabled
firefox71 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

STR:

  1. open nightly
  2. open about:config (if there's no warning, search for the general.warnOnAboutConfig pref and toggle it to the default)
  3. tab/shift-tab to get to checkbox

ER:
blue outline on checkbox when focused

AR:
no outline

Unsure if this is a regression in HTML-about:config or just a regression in going from XUL about:config to HTML about:config - but either way it's a regression.

On Mac, there's really no styles. On Windows, there's only the default faint grey outline, so although in principle there's at least some focus indication, to be using the same consistent in-content style really something else would have to be done there, too.

I don't know if this affects other in-content checkboxes.

Summary: No focus outline on html about:config warning checkbox when tabbing to it → No focus outline on in-content checkboxes when tabbing to them (e.g. warning in about:config, "show subsession data" in about:telemetry, etc.)

(In reply to :Gijs (he/him) from comment #0)

I don't know if this affects other in-content checkboxes.

Turns out it does...

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8a7bea382687
add focus outline to in-content html checkboxes, r=dao
See Also: → 1579917
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Flags: qe-verify+

I have managed to reproduce the issue using Ubuntu 18.04 LTS using Fx 71.0a1 (2019-09-02) I can confirm that the issue is fixed on Fx 71.0b11 on all OS platforms.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: