1579460 - No focus outline on in-content checkboxes when tabbing to them (e.g. warning in about:config, "show subsession data" in about:telemetry, etc.)

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[:Gijs (he/him)]

STR:

1. open nightly
2. open about:config (if there's no warning, search for the general.warnOnAboutConfig pref and toggle it to the default)
3. tab/shift-tab to get to checkbox

ER:
blue outline on checkbox when focused

AR:
no outline

Unsure if this is a regression in HTML-about:config or just a regression in going from XUL about:config to HTML about:config - but either way it's a regression.

On Mac, there's really no styles. On Windows, there's only the default faint grey outline, so although in principle there's at least some focus indication, to be using the same consistent in-content style really something else would have to be done there, too.

I don't know if this affects other in-content checkboxes.

Comment 1

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #0)

I don't know if this affects other in-content checkboxes.

Turns out it does...

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1579460 - add focus outline to in-content html checkboxes, r?dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a7bea382687
add focus outline to in-content html checkboxes, r=dao

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/8a7bea382687

Comment 5

[Negritas Sergiu, Desktop QA]

I have managed to reproduce the issue using Ubuntu 18.04 LTS using Fx 71.0a1 (2019-09-02) I can confirm that the issue is fixed on Fx 71.0b11 on all OS platforms.