Closed Bug 1579461 Opened 2 months ago Closed 2 months ago

Implement modern method (mutate) of removing credentials from a url

Categories

(Thunderbird :: Message Reader UI, defect)

defect
Not set

Tracking

(thunderbird_esr6869+ fixed, thunderbird70 fixed, thunderbird71 fixed)

RESOLVED FIXED
Thunderbird 71.0
Tracking Status
thunderbird_esr68 69+ fixed
thunderbird70 --- fixed
thunderbird71 --- fixed

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch mutate.patch (obsolete) — Splinter Review
Assignee: nobody → alta88
Attachment #9091075 - Flags: review?(jorgk)
Comment on attachment 9091075 [details] [diff] [review]
mutate.patch

Please get rid of the local variables. We always write it like this:

url = makeURI(url).mutate().setUsername("").setUserPass("").finalize().spec;
Attachment #9091075 - Flags: review?(jorgk) → review+
Attached patch mutate.patchSplinter Review
Attachment #9091075 - Attachment is obsolete: true
Attachment #9091130 - Flags: review+

fixed for lint too.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1bffbb9820b3
Implement modern method (mutate) of removing credentials from a url in msgHdrView.js. r=jorgk

Status: NEW → RESOLVED
Closed: 2 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
Comment on attachment 9091130 [details] [diff] [review]
mutate.patch

To fix merge conflicts with bug 1579341.
Attachment #9091130 - Flags: approval-comm-esr68+
Attachment #9091130 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.