Closed Bug 1579495 Opened 3 months ago Closed 3 months ago

Unrestrict eval telemetry on beta

Categories

(Core :: DOM: Security, task, P2)

task

Tracking

()

RESOLVED FIXED
Tracking Status
firefox69 --- unaffected
firefox70 - fixed
firefox71 --- unaffected

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 obsolete file)

The intent here was to collect telemetry from Beta 70 (with no enforcement) and then Nightly 71 would enforce it.

But I forgot we had Nightly guards on the function call so we're not calling it on Beta or sending in Telemetry.

So I'm asking for Beta uplift here to remove the Nightly guards.

[Tracking Requested - why for this release]: The intent here is to remove Nightly guards from something we want to call in Beta

Status: NEW → ASSIGNED
Type: defect → task
Priority: -- → P2
Whiteboard: [domsecurity-active]

Comment on attachment 9091124 [details]
Bug 1579495 - Remove Nightly guards on eval telemetry r?ckerschb

Beta/Release Uplift Approval Request

  • User impact if declined: We'll have to wait another cycle until we can begin enforcement of this security feature.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): We'll calling a new codepath that submits telemetry events. It's possible an unexpected environment difference between beta and Nightly could lead to getting flooded with telemetry.
  • String changes made/needed:
Attachment #9091124 - Flags: approval-mozilla-beta?

Comment on attachment 9091124 [details]
Bug 1579495 - Remove Nightly guards on eval telemetry r?ckerschb

Enabling this telemetry in beta 6.

Attachment #9091124 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Please keep an eye on whether we're flooded with telemetry or not on Friday when we release beta 6.

Flags: needinfo?(tom)

This isn't landing in central, so it's fixed, but leaving the ni open for me to confirm about Telemetry.

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED

We are not flooded.

Flags: needinfo?(tom)
Attachment #9091124 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.