Closed Bug 1579530 Opened 2 years ago Closed 2 years ago

Popup should validate the preference state

Categories

(Core :: Gecko Profiler, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

Details

Attachments

(1 file)

Right now we don't validate the contents of the preference for the popup. This can lead to weird behavior.

  • Turn profiler on
  • Close browser
  • Re-open
  • Hit keyboard shortcut to start profiler
  • Nothing happens

Or

  • Remove a profiler feature
  • Someone else had it enabled
  • They run the profiler.
  • Crash, unknown feature.
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf79c0e479c1
Validate the popup preferences; r=julienw
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.