1579585 - Crash in [@ OOM | large | mozalloc_abort | mozalloc_handle_oom | gkrust_shared::oom_hook::hook | std::alloc::rust_oom | std::collections::hash::map::HashMap<T>::try_resize<T> | std::collections::hash::set::HashSet<T>::insert<T>]

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Asif Youssuff]

This bug is for crash report bp-5a9746e4-1bd0-4175-9d0c-a5a880190906.

Top 10 frames of crashing thread:

0 mozglue.dll mozalloc_abort memory/mozalloc/mozalloc_abort.cpp:33
1 mozglue.dll mozalloc_handle_oom memory/mozalloc/mozalloc_oom.cpp:51
2 xul.dll void gkrust_shared::oom_hook::hook toolkit/library/rust/shared/lib.rs:267
3 xul.dll void std::alloc::rust_oom src/libstd/alloc.rs:211
4 xul.dll void alloc::alloc::handle_alloc_error src/liballoc/alloc.rs:227
5 xul.dll static union core::result::Result< src/libstd/collections/hash/map.rs:1118
6 xul.dll static bool std::collections::hash::set::HashSet<style::invalidation::stylesheets::Invalidation, core::hash::BuildHasherDefault<fxhash::FxHasher>>::insert<style::invalidation::stylesheets::Invalidation, core::hash::BuildHasherDefault<fxhash::FxHasher>> src/libstd/collections/hash/set.rs:681
7 xul.dll static void style::stylesheet_set::DocumentStylesheetSet<style::gecko::data::GeckoStyleSheet>::collect_invalidations_for<style::gecko::data::GeckoStyleSheet> servo/components/style/stylesheet_set.rs
8 xul.dll void geckoservo::glue::Servo_StyleSet_AppendStyleSheet servo/ports/geckolib/glue.rs:1466
9 xul.dll mozilla::ServoStyleSet::AppendStyleSheet layout/style/ServoStyleSet.cpp:572

Comment 1

[Eric Rahm [:erahm]]

Looks like an oom in style-related code.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

We can try to use fallible allocation here and invalidate the whole document otherwise, or something.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1579585 - Use fallible allocation for stylesheet invalidation.

If the sets get too big we cannot allocate anything else, we'll just empty them
and invalidate the whole document.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b26a35cc0a17
Use fallible allocation for stylesheet invalidation. r=jwatt

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b26a35cc0a17

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9094685 [details]
Bug 1579585 - Use fallible allocation for stylesheet invalidation.

Beta/Release Uplift Approval Request

• User impact if declined: Potential OOM crashes.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change insertion to be fallible and invalidate the whole document, clearing the sets while at it.
• String changes made/needed: none

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9094685 [details]
Bug 1579585 - Use fallible allocation for stylesheet invalidation.

Fix for OOM crashes, let's uplift for beta 11.

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/edac1bbc6240

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This is low enough volume that I don't think we need to worry about it for ESR68.