1579612 - Wrong html entity in history dropdown with non-latin tags

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[zhouck]

Attachment: screenshot-75.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

Open history dropdown

Actual results:

Most of history entries contains some weird unicode entity

Expected results:

History entry should not contains any weird characters

Comment 1

[zhouck]

Probably, this entity adds due to non-latin tags

Comment 2

[Marco Bonardo [:mak]]

Could you please post some examples of the tags in unicode chars?

Comment 3

[Marco Bonardo [:mak]]

Could you please post some examples of the tags in unicode chars?

Comment 4

[zhouck]

like in screenshot: ьщяшддф, ьшскщіщае etc

These are latin tag entered in cyrillic layout.

Comment 5

[Drew Willcoxon :adw]

Bug 1567301 regressed this.

STR

1. Visit https://www.pravda.com.ua/
2. Bookmark it and give it the tag ьщяшддф
3. Click the history dropdown

The Pravda entry will have a unicode replacement char like in the screenshot in comment 0.

Comment 6

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: tags_IF.png

Hello! Here is the STR I use to reproduce the issue so there is no need for Unicode characters:

1. Open Firefox and bookmark a random webpage with a random tag(e.g Tags=a).
2. Search #NamOfTheTag in the URL bar (e.g. #a).

Attached a screenshot.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix in 70 but we can still take a patch for 72 and potentially 71.
Drew, can you assign a priority and help find an owner for this bug? Thanks!

Comment 8

[Drew Willcoxon :adw]

Thanks for the further info, Alexandru. I'll look into this.

Comment 9

[Drew Willcoxon :adw]

Attachment: Bug 1579612 - Properly extract tags from urlbar results in all cases.

We extract tags from the result title only when info.style.includes("bookmark"), but that only captures one of the two cases where we include tags in the title: the "bookmark" style. We also include tags for the "tag" style. So the bug reports in this bug are hitting that "tag" case. It doesn't have anything to do with non-Latin tags afaict (see the bug summary).

I took the opportunity to streamline UnifiedComplete._addFilteredQueryMatch, which was a little hard to follow. I had to look at it to make sure I captured all the cases where tags are included in the title. I think I've made it easier to follow.

Comment 10

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b699f116dc0241b593aa69c3800369519e7e0811

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ecc1f71e078
Properly extract tags from urlbar results in all cases. r=mak

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6ecc1f71e078

Comment 13

[Anca Soncutean, Desktop QA]

I've reproduce this issue with Fx 71.0a1 (2019-09-07) on Windows 10 x64.
The issue is verified fixed with Fx 72.0a1 (2019-11-03) and Fx 71.0b6 on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 x64.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

This looks pretty ugly, did you want to nominate the patch for ESR68 uplift? It grafts cleanly as-landed.

Comment 15

[Drew Willcoxon :adw]

Comment on attachment 9101026 [details]
Bug 1579612 - Properly extract tags from urlbar results in all cases.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes an ugly regression.
• User impact if declined: In some cases, pages that the user has tagged will show up in the urlbar view with a missing unicode entity.
• Fix Landed on Version: 71
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch and the related code has extensive tests. This has baked since 71.
• String or UUID changes made by this patch:

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9101026 [details]
Bug 1579612 - Properly extract tags from urlbar results in all cases.

Fix for a fairly bad regression in 68.1esr, let's uplift for 68.3esr.

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/4bfc3dab67ef

Comment 18

[Anca Soncutean, Desktop QA]

The issue is verified fixed with Fx 68.3esr (treeherder build provided in comment 17) on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64.