1579655 - [Translate.Next] Write tests for the fluentoriginal module

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P4)

Description

[Matjaz Horvat [:mathjazz]]

We don't have any unit tests in modules/fluentoriginal.

It would be nice to add some, catching things like bug 1579632.

Comment 1

[Viktor Stojanov [:Draci]]

Hi, I'm an Outreachy applicant and this seems like the only bug for now. Can I have a crack at it?
Thank you!

Comment 2

[Matjaz Horvat [:mathjazz]]

Hi Viktor, the bug is now assigned to you!

Adrian will get back to you with more details.

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Hi Viktor, thanks for offering to contribute.

Before anything else, if you haven't done so yet, please install Pontoon and make sure it works locally. Instructions are here: https://mozilla-pontoon.readthedocs.io/en/latest/dev/setup.html

This bug is about a piece of Translate.Next, and the code lives in the frontend folder. You can read the documentation specific to this here: https://github.com/mozilla/pontoon/blob/master/frontend/README.md

The files this is about are here: https://github.com/mozilla/pontoon/tree/master/frontend/src/modules/fluentoriginal/components

They are React components that are not tested, and we would like to have some coverage there. Basically, that means adding a .test.js file for each .js file in that folder, and writing comprehensive tests for each functionality. Doing that requires to understand what each component does, so you'll have to read the code of each module.

There are many examples of tests in our code base, you can find them around by their name ending in .test.js. Here's one: https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/fluenteditor/components/RichTranslationForm.test.js

To run only the frontend tests, use this command from the root of the Pontoon directory: make test-frontend.

Comment 4

[Matjaz Horvat [:mathjazz]]

We're getting lots of requests by Outreachy participants, so we often run out of Mentored bugs. We've decided to unassign all Mentored bugs until the assignee sets up a development environment.
​
Please send us a screenshot of your working development environment via #pontoon on Mozilla IRC and we'll assign you a Mentored bug afterwards.
​
Thanks for understanding!

Comment 5

[Matjaz Horvat [:mathjazz]]

Hi :Draci, are you still working on this bug?

Comment 6

[Viktor Stojanov [:Draci]]

Hi :mathjazz, please assign this bug to someone else. Personal life got in the way for this season of Outreachy so I'll not be able to complete it. I will apply next year when I'll hopefully not have family emergencies and I'll learn more about unit testing.

Thank you for understanding!

Comment 7

[Matjaz Horvat [:mathjazz]]

Thanks for an honest response. Wishing you all the best!

Comment 8

[Nadinda Rachmat [:nadinda]]

Can I give it a try on this if it’s still available?

Comment 9

[Matjaz Horvat [:mathjazz]]

Of course! :) Assigning.

Comment 10

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1446

Comment 11

[Matjaz Horvat [:mathjazz]]

https://github.com/mozilla/pontoon/commit/f7200688e30d5d90bda327d570149a5468d07652