Closed Bug 1579679 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18919 - Portals: separate contents lifetime from element lifetime.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18919 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18919
Details from upstream follow.

Jeremy Roman <jbroman@chromium.org> wrote:

Portals: separate contents lifetime from element lifetime.

A portal contents briefly has some work to do after the activate()
operation is called, but from a spec perspective this operation
detaches from the \<portal> element and should be largely independent
of it from that point onward.

To express this separation between the element which hosts the
WebContents and the management of the WebContents itself
(in the renderer process), this breaks HTMLPortalElement into two
classes, one for each.

DocumentPortals then needs only to track the existing contents,
and HTMLPortalElement doesn't need to keep around an is_activating_
boolean, as it no longer has guest contents the moment activation
begins.

For convenience, PortalContents is directly aware of whether it is
in an element, since communication back to the element is still
required and implementing a PortalContentsClient interface seems
like overkill at this point.

Bug: 964481
Change-Id: I9b394e34f64b891fe013f7ae48a8aaf00ed06d30

Reviewed-on: https://chromium-review.googlesource.com/1789466
WPT-Export-Revision: 173d4032e4447fff49e2d0fefdf45c7531f34355

Ran 1 tests and 1 subtests
TIMEOUT: 2

New tests that have failures or other problems:
/portals/portals-set-src-after-activate.html: TIMEOUT
    Tests that a portal element can be fully reused after activate has detached it: TIMEOUT
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86e2b4d076a9
[wpt PR 18919] - Portals: separate contents lifetime from element lifetime., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/e38ac1f54c74
[wpt PR 18919] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.