Closed Bug 1579698 Opened 1 year ago Closed 5 months ago

Make TestMailCookie work again

Categories

(MailNews Core :: Testing Infrastructure, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1543219 +++

Executing mach gtest TestMailCookie* fails again after making it work in bug 1543219 :-(

I haven't looked why it fails now, but it would be due to some cookie changes in M-C.

Assignee: nobody → jorgk
This is how gtest docs say to temporarily disable a test, and is the method
used by Firefox.
Attachment #9092246 - Flags: review?(jorgk)
Assignee: jorgk → rob
Status: NEW → ASSIGNED
Assignee: rob → jorgk
Comment on attachment 9092246 [details] [diff] [review]
disable_testmailcookie.patch

OK, thanks.
Attachment #9092246 - Flags: review?(jorgk) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/067075632f1f
Temporarily disable TestMailCookie gtests. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Thunderbird 71.0 → ---
Status: REOPENED → ASSIGNED

Fortunately the thing still works after a string tweak. I've never heard of VoidCString(), but that's what M-C use in their test here:
https://searchfox.org/mozilla-central/rev/153feabebc2d13bb4c29ef8adf104ec1ebd246ae/netwerk/test/TestCookie.cpp#77

First reviewer wins ;-)

Attachment #9094732 - Flags: review?(mkmelin+mozilla)
Attachment #9094732 - Flags: review?(acelists)
Comment on attachment 9094732 [details] [diff] [review]
1579698-fix-test-mail-cookie.patch

Review of attachment 9094732 [details] [diff] [review]:
-----------------------------------------------------------------

OK, thanks.
Attachment #9094732 - Flags: review?(acelists) → review+
Comment on attachment 9094732 [details] [diff] [review]
1579698-fix-test-mail-cookie.patch

That was quick ;-)
Attachment #9094732 - Flags: review?(mkmelin+mozilla)
Target Milestone: --- → Thunderbird 71.0

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b72fde123f32
Don't call nsDependentCString(nullptr) since it crashes TestMailCookie. r=aceman

Status: ASSIGNED → RESOLVED
Closed: 5 months ago5 months ago
Resolution: --- → FIXED

Looks like I messed it up myself here when changing to "smart strings":
https://hg.mozilla.org/comm-central/rev/f22dd6d49717e8484fe1cc5994e0c3f844193a3e#l3.31

You need to log in before you can comment on or make changes to this bug.