1579698 - Make TestMailCookie work again

Status: RESOLVED FIXED

(MailNews Core :: Testing Infrastructure, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1543219 +++

Executing mach gtest TestMailCookie* fails again after making it work in bug 1543219 :-(

I haven't looked why it fails now, but it would be due to some cookie changes in M-C.

Comment 1

[Rob Lemley [:rjl]]

Attachment: disable_testmailcookie.patch

This is how gtest docs say to temporarily disable a test, and is the method
used by Firefox.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9092246 [details] [diff] [review]
disable_testmailcookie.patch

OK, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/067075632f1f
Temporarily disable TestMailCookie gtests. r=jorgk

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1579698-fix-test-mail-cookie.patch

Fortunately the thing still works after a string tweak. I've never heard of VoidCString(), but that's what M-C use in their test here:
https://searchfox.org/mozilla-central/rev/153feabebc2d13bb4c29ef8adf104ec1ebd246ae/netwerk/test/TestCookie.cpp#77

First reviewer wins ;-)

Comment 5

[:aceman]

Comment on attachment 9094732 [details] [diff] [review]
1579698-fix-test-mail-cookie.patch

Review of attachment 9094732 [details] [diff] [review]:
-----------------------------------------------------------------

OK, thanks.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9094732 [details] [diff] [review]
1579698-fix-test-mail-cookie.patch

That was quick ;-)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b72fde123f32
Don't call nsDependentCString(nullptr) since it crashes TestMailCookie. r=aceman

Comment 8

[Jorg K (CEST = GMT+2)]

Looks like I messed it up myself here when changing to "smart strings":
https://hg.mozilla.org/comm-central/rev/f22dd6d49717e8484fe1cc5994e0c3f844193a3e#l3.31