Closed Bug 1579728 Opened 11 months ago Closed 11 months ago

Ignore tombstones for nonexistent items when merging bookmarks

Categories

(Firefox :: Sync, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox69 --- disabled
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: lina, Assigned: lina)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

See bp-ad46895e-eb33-47ba-89b2-5d0480190905 for an example—the tree is pretty small (2.5k bookmarks), but there are over 1m tombstones ({"step":"merge","at":1567665986347,"took":970,"counts":[{"name":"items","count":2522},{"name":"deletes","count":1641866}]}). We'll insert entries for all of them into itemsToRemove, even if we don't actually do anything with them because they don't exist locally, and don't need to be uploaded.

Assignee: nobody → lina
Status: NEW → ASSIGNED

Taking this early so we can uplift to 70.

On second thought, this is going to be a pretty big patch to uplift, so letting this ride the train seems prudent.

The latest version of Dogear adds completion ops for deleting local
items (to apply incoming tombstones), inserting new local tombstones
(to stage deletions for non-syncable and invalid items), and uploading
tombstones (to avoid an extra scan of moz_bookmarks_deleted).

These ops are only emitted for GUIDs that are mentioned, either as
items or tombstones, in both trees. This means we won't try to apply
tombstones for items that don't exist in Places, or upload tombstones
for items that aren't on the server.

Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/faabf87693c1
Use completion ops to upload synced bookmark tombstones. r=markh
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.