Closed Bug 1579765 Opened 5 years ago Closed 5 years ago

Fix DocumentChannel WPT test failure

Categories

(Core :: Networking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Fission Milestone M4
Tracking Status
firefox71 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(4 files, 1 obsolete file)

DocumentChannel is currently disabled (waiting for parent intercept service workers). It looks like when we enable it, there will be a couple of WPT failures.

Filing this bug to track the fixes for those.

If the docshell explicitly set this property with a nullptr value, then we should just return that.
This fixes a warning where we try QI a DocumentChannelChild to nsIHttpChannel when looking for the referrer.

Depends on D45148

DocumentChannel doesn't use the REDIRECT_INTERNAL flag when replacing itself with a real channel if there has been a real redirect handled in the parent.
This is so that the docshell knows about the URI change, and to add history entries.
The timing data however always wanted to be treated as an internal redirect, so that we don't record a new 'redirectEnd' at the time of the switch.
This adds a new parameter to ConfigureReplacementChannel so that we can more accurately describe the behaviour we need.

Depends on D45149

Priority: -- → P2
Whiteboard: [necko-triaged]
Attachment #9091338 - Attachment description: Bug 1579765 - Early exit from NS_GetReferrrerFromChannel if we had the internalReferrer property. r?mayhemer → Bug 1579765 - Early exit from NS_GetReferrerFromChannel if we had the internalReferrer property. r?mayhemer
Attachment #9091336 - Attachment is obsolete: true
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61d263894d0e
Move upload stream handling into ReplacementChannelConfig so that it gets applied to DocumentChannel as well as normal HTTP redirects. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/97d550c3ac10
Copy mResultPrincipalURI across when serializing nsDocShellLoadState. r=kmag
https://hg.mozilla.org/integration/autoland/rev/fe9567931ae2
Early exit from NS_GetReferrerFromChannel if we had the internalReferrer property. r=mayhemer,smaug
https://hg.mozilla.org/integration/autoland/rev/dab9b571a967
Don't overwrite redirect timings when we convert DocumentChannel to a real channel. r=mayhemer

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: