1579767 - Search one-offs container has incorrect accessibility role

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[James Teh [:Jamie]]

STR (with the NVDA screen reader):

1. Press alt+d to focus the address bar.
2. Type: test
3. Press up arrow. You may need to press it twice if bug 1567384 comment 16 isn't fixed yet.
   • Expected: NVDA should say "This time, search with: grouping"
   • Actual: NVDA says "This time, search with: box"

This was regressed in bug 1561894. Previously, this was a <description> with role="group". In bug 1561894, the structure was changed and the role="group" was removed.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1579767: Reinstate the accessibility group role for the search one-offs container.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf56deedc6b7
Reinstate the accessibility group role for the search one-offs container. r=dao

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bf56deedc6b7

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

please ask for uplift when possible.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

[Tracking Requested - why for this release]: accessibility regression

Comment 6

[James Teh [:Jamie]]

Comment on attachment 9091341 [details]
Bug 1579767: Reinstate the accessibility group role for the search one-offs container.

Beta/Release Uplift Approval Request

• User impact if declined: Minor incorrect information reported for accessibility clients such as screen readers.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch which just adds a markup attribute that only impacts accessibility.
• String changes made/needed: None.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9091341 [details]
Bug 1579767: Reinstate the accessibility group role for the search one-offs container.

Accessibility fix for new regression in 70, let's uplift for beta 7.

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/a86e16a48e8c

Comment 9

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 70.0a1 (BuildId:20190801214227) on Windows 10 64bit (with NVDA enabled).

This issue is verified fixed using Firefox 71.0a1 (BuildId:20190916155843) and Firefox 70.0b7 (BuildId:20190916074538) on Windows 10 64bit with NVDA.