Closed Bug 1579794 Opened 2 years ago Closed 2 years ago

[Wayland] Flickering on video playback on 4k/HiDPI displays

Categories

(Core :: Widget: Gtk, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

Details

Attachments

(3 files)

There's flickering on video playback on 4k/HiDPI displays on Wayland backend caused by various issues.

Use wl_surface_damage_buffer() to propagate wl_buffer damage to avoid rounding errors and
rendering artifacts for HiDPI wl_buffers.

Depends on D45165

Recently direct wl_buffer rendering is kept enabled until we have wl_buffer available which
produces rendering artifacts when screen damage rects overlaps.

Let's enable/disable it explicitly at every rendering cycle start to avoid
screen flickering.

Depends on D45166

Priority: -- → P2

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/445defbb3ebb
[Wayland] Copy pixel data for cached images, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/4ac77b1b0aa8
[Wayland] Use wl_surface_damage_buffer() and require wl_compositor v.4, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/c5836cbc0b3e
[Wayland] Explicitly enable/disable direct rendering to wl_buffer, r=jhorak

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Depends on: 1577024

Comment on attachment 9091375 [details]
Bug 1579794 - [Wayland] Copy pixel data for cached images, r=jhorak

Beta/Release Uplift Approval Request

  • User impact if declined: Rendering artifacts on Linux/Wayland.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only.
  • String changes made/needed:
Attachment #9091375 - Flags: approval-mozilla-beta?
Attachment #9091376 - Flags: approval-mozilla-beta?
Attachment #9091377 - Flags: approval-mozilla-beta?

Comment on attachment 9091375 [details]
Bug 1579794 - [Wayland] Copy pixel data for cached images, r=jhorak

Better support for Wayland, fine for uplift during early beta.

Attachment #9091375 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9091376 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9091377 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.