1579794 - [Wayland] Flickering on video playback on 4k/HiDPI displays

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

There's flickering on video playback on 4k/HiDPI displays on Wayland backend caused by various issues.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1579794 - [Wayland] Copy pixel data for cached images, r=jhorak

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1579794 - [Wayland] Use wl_surface_damage_buffer() and require wl_compositor v.4, r=jhorak

Use wl_surface_damage_buffer() to propagate wl_buffer damage to avoid rounding errors and
rendering artifacts for HiDPI wl_buffers.

Depends on D45165

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1579794 - [Wayland] Explicitly enable/disable direct rendering to wl_buffer, r=jhorak

Recently direct wl_buffer rendering is kept enabled until we have wl_buffer available which
produces rendering artifacts when screen damage rects overlaps.

Let's enable/disable it explicitly at every rendering cycle start to avoid
screen flickering.

Depends on D45166

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/445defbb3ebb
[Wayland] Copy pixel data for cached images, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/4ac77b1b0aa8
[Wayland] Use wl_surface_damage_buffer() and require wl_compositor v.4, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/c5836cbc0b3e
[Wayland] Explicitly enable/disable direct rendering to wl_buffer, r=jhorak

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/445defbb3ebb
https://hg.mozilla.org/mozilla-central/rev/4ac77b1b0aa8
https://hg.mozilla.org/mozilla-central/rev/c5836cbc0b3e

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9091375 [details]
Bug 1579794 - [Wayland] Copy pixel data for cached images, r=jhorak

Beta/Release Uplift Approval Request

• User impact if declined: Rendering artifacts on Linux/Wayland.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only.
• String changes made/needed:

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9091375 [details]
Bug 1579794 - [Wayland] Copy pixel data for cached images, r=jhorak

Better support for Wayland, fine for uplift during early beta.

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/938228e585eb
https://hg.mozilla.org/releases/mozilla-beta/rev/005bb5c002cc
https://hg.mozilla.org/releases/mozilla-beta/rev/172128453e54