Closed Bug 1579795 Opened 2 months ago Closed Last month

Improve handling of errors when fetching the manifest

Categories

(DevTools :: Application Panel, enhancement, P1)

enhancement

Tracking

(firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: ladybenko, Assigned: ladybenko)

References

(Blocks 1 open bug)

Details

(Whiteboard: [manifest-reserve])

Attachments

(4 files)

There are cases where we can get an exception we're not currently handling (i.e. by getFront, etc.). We should fix this by making the fetchManifest service to throw, and then using try / catch for the async action.

See discussion here for more details: https://phabricator.services.mozilla.com/D44668?id=158130#inline-272673

Priority: -- → P3
Assignee: nobody → ogasidlo
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [manifest-reserve]

Assigning this bug to myself because Ola is on leave and she asked me in Slack to take care of this bug.

Assignee: ogasidlo → balbeza
See Also: → 1589597
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/193f93f381cd
Part 1: Improve error handling when fetching the manifest r=jdescottes,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/eb0eaf505108
Part 2: Reorganize jest tests folder structure r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/141f065f3788
Part 3: Test the fetchManifest action separately r=jdescottes
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93652298c256
Part 1: Improve error handling when fetching the manifest r=jdescottes,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/2e302d7607cb
Part 2: Reorganize jest tests folder structure r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/9d0d9c65ec9e
Part 3: Test the fetchManifest action separately r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Flags: needinfo?(balbeza)
You need to log in before you can comment on or make changes to this bug.