Improve handling of errors when fetching the manifest
Categories
(DevTools :: Application Panel, enhancement, P1)
Tracking
(firefox72 fixed)
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: ladybenko, Assigned: ladybenko)
References
(Blocks 1 open bug)
Details
(Whiteboard: [manifest-reserve])
Attachments
(4 files)
There are cases where we can get an exception we're not currently handling (i.e. by getFront
, etc.). We should fix this by making the fetchManifest
service to throw, and then using try
/ catch
for the async action.
See discussion here for more details: https://phabricator.services.mozilla.com/D44668?id=158130#inline-272673
Updated•5 years ago
|
Throwing error when we have a errorMessage and catch it
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Assigning this bug to myself because Ola is on leave and she asked me in Slack to take care of this bug.
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Pushed by balbeza@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/193f93f381cd Part 1: Improve error handling when fetching the manifest r=jdescottes,fluent-reviewers,flod https://hg.mozilla.org/integration/autoland/rev/eb0eaf505108 Part 2: Reorganize jest tests folder structure r=jdescottes https://hg.mozilla.org/integration/autoland/rev/141f065f3788 Part 3: Test the fetchManifest action separately r=jdescottes
Comment 7•5 years ago
|
||
Backed out 3 changesets (bug 1579795) for causing devtools node failures
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271917630&repo=autoland&lineNumber=1030
Backout: https://hg.mozilla.org/integration/autoland/rev/4ad0eb343fac8037f7226c04ad7f1f8a76147426
Pushed by balbeza@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93652298c256 Part 1: Improve error handling when fetching the manifest r=jdescottes,fluent-reviewers,flod https://hg.mozilla.org/integration/autoland/rev/2e302d7607cb Part 2: Reorganize jest tests folder structure r=jdescottes https://hg.mozilla.org/integration/autoland/rev/9d0d9c65ec9e Part 3: Test the fetchManifest action separately r=jdescottes
Comment 9•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/93652298c256
https://hg.mozilla.org/mozilla-central/rev/2e302d7607cb
https://hg.mozilla.org/mozilla-central/rev/9d0d9c65ec9e
Assignee | ||
Updated•5 years ago
|
Description
•