Closed Bug 15798 Opened 25 years ago Closed 24 years ago

[feature] Overlays do not yet support removing elements and attributes

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.0

People

(Reporter: hangas, Assigned: bugs)

References

Details

(Keywords: helpwanted) 

Overlays to not support removing elements and removing attributes from elements.
Adding at the request of hyatt.
Blocks: 15797
Status: NEW → ASSIGNED
Target Milestone: M18
Summary: Overlays do not yet support removing elements and attributes → [feature] Overlays do not yet support removing elements and attributes
No time left in this release, resolving as later, putting on helpwanted radar
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Keywords: helpwanted
Resolution: --- → LATER
reopening all latered bugs
Status: RESOLVED → REOPENED
Resolution: LATER → ---
Moving all latered bugs to M20 as ordered by project manager.  Although these 
bugs are now open, assigned and targetted, XPToolkit has no plans to 
fix/implement them in the current release cycle, if ever.
Target Milestone: M18 → M20
Mass move of all M20 bugs to M30.
Mass move of M20 bugs to M30
Target Milestone: M20 → M30
Mass-moving all M20-M30 XPToolkit bugs to Future
Target Milestone: M30 → Future
assigning to myself so hyatt can't take credit for the fix when I check in my
patches...

(:p:p)
Assignee: hyatt → ben
Status: REOPENED → NEW
'XUL Stuff That Should Be Done'
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla1.0
Changing component.

I have a patch for the element removal side of this (hyatt has reviewed,
waterson is super-reviewing). Attributes can be "removed" (for most intents and
purposes) by setting it to "" in the overlay.
Component: XP Toolkit/Widgets → XP Toolkit/Widgets: XUL
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
Well, this is now supported, add remove="true" on a node to have it removed from
the document.

Attributes can be 'removed' by simply setting to "" in the overlay. Sure this
isn't real removal, so hasAttribute will still return true, but since no one in
the FE ever calls hasAttribute, this seems reasonable ;)
QA Contact: claudius → jrgm
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.