1579805 - Allow browser.messages.query to find read or unread messages

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Marvin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36

Steps to reproduce:

I tried making a Gloda message query with the parameter "read".
browser.messages.query({"read":false})

Actual results:

Error: Type error for parameter queryInfo (Unexpected property "read") for messages.query.

Expected results:

a messagelist with the messages which are unread

Comment 1

[Marvin]

Darktrojan and I worked on a workaround for the read parameter.
I attached said workaround.

Comment 2

[Marvin]

Attachment: workaround for read param (row: 63 to 73)

Comment 3

[Marvin]

Can we get this into the Daylie version?

Comment 4

[Jorg K (CEST = GMT+2)]

Can you turn this into a patch and ask for review? Or at least tell me which file you're changing and I can do the patch. Looking at this again, this is add-on code, right? This is not in our code base.

Comment 5

[Marvin]

to be honest... I dont know how to turn it into a patch...
I just built it and like last time I hoped that Darktrojan would turn it into a patch.
I do believe that it is somewhere in your code base under the browser.message otherwise I wouldnt be able to use it currently.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1579805-messages-read-1.diff

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e30fb2f1bc3f
Allow browser.messages.query to find read or unread messages. r=mkmelin

Comment 8

[Jorg K (CEST = GMT+2)]

Any uplifts here? I guess it won't be of much use in TB 71+

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 9093858 [details] [diff] [review]
1579805-messages-read-1.diff

Doesn't look like a terribly complicated change, so OK to take it.

Comment 10

[Jorg K (CEST = GMT+2)]

TB 70 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/c03da831ba4de330d0986c5b9dcbca1227af0c7b

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 9093858 [details] [diff] [review]
1579805-messages-read-1.diff

No one answered the question as to whether this needed uplift. So I stuck it onto TB 70 beta. The patch doesn't apply to TB 68 at all. So if you want it backported, please rebase it.

Comment 12

[Geoff Lankow (:darktrojan)]

Attachment: 1579805-messages-read-esr.diff

Comment 13

[Jorg K (CEST = GMT+2)]

TB 68.2.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/e21cbc9dab4a878d0f1740d73a176da1e1b7dae1