Closed Bug 1579805 Opened Last month Closed Last month

Allow browser.messages.query to find read or unread messages

Categories

(Thunderbird :: Add-Ons: Extensions API, enhancement)

enhancement
Not set

Tracking

(thunderbird_esr6870+ fixed, thunderbird70 fixed, thunderbird71 fixed)

RESOLVED FIXED
Thunderbird 71.0
Tracking Status
thunderbird_esr68 70+ fixed
thunderbird70 --- fixed
thunderbird71 --- fixed

People

(Reporter: hermar05, Assigned: darktrojan)

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36

Steps to reproduce:

I tried making a Gloda message query with the parameter "read".
browser.messages.query({"read":false})

Actual results:

Error: Type error for parameter queryInfo (Unexpected property "read") for messages.query.

Expected results:

a messagelist with the messages which are unread

Darktrojan and I worked on a workaround for the read parameter.
I attached said workaround.

Can we get this into the Daylie version?

Can you turn this into a patch and ask for review? Or at least tell me which file you're changing and I can do the patch. Looking at this again, this is add-on code, right? This is not in our code base.

to be honest... I dont know how to turn it into a patch...
I just built it and like last time I hoped that Darktrojan would turn it into a patch.
I do believe that it is somewhere in your code base under the browser.message otherwise I wouldnt be able to use it currently.

Flags: needinfo?(geoff)
Assignee: nobody → geoff
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(geoff)
Attachment #9093858 - Flags: review?(mkmelin+mozilla)
Summary: Gloda Query with read returns unexpected property error → Allow browser.messages.query to find read or unread messages
Attachment #9093858 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e30fb2f1bc3f
Allow browser.messages.query to find read or unread messages. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: Last month
Keywords: checkin-needed
Resolution: --- → FIXED

Any uplifts here? I guess it won't be of much use in TB 71+

Target Milestone: --- → Thunderbird 71.0
Comment on attachment 9093858 [details] [diff] [review]
1579805-messages-read-1.diff

Doesn't look like a terribly complicated change, so OK to take it.
Attachment #9093858 - Flags: approval-comm-esr68+
Attachment #9093858 - Flags: approval-comm-beta+
Component: Untriaged → Add-Ons: Extensions API
Comment on attachment 9093858 [details] [diff] [review]
1579805-messages-read-1.diff

No one answered the question as to whether this needed uplift. So I stuck it onto TB 70 beta. The patch doesn't apply to TB 68 at all. So if you want it backported, please rebase it.
Flags: needinfo?(geoff)
Attachment #9093858 - Flags: approval-comm-esr68+ → approval-comm-esr68?
Flags: needinfo?(geoff)
Attachment #9099801 - Flags: approval-comm-esr68?
Attachment #9093858 - Flags: approval-comm-esr68?
Attachment #9099801 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.