Closed
Bug 1579823
Opened 4 years ago
Closed 4 years ago
[Wayland] remove __PRETTY_FUNCTION__ from wayland logs as it produces too long function names
Categories
(Core :: Widget: Gtk, enhancement)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla71
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
PRETTY_FUNCTION is too long and makes the logs confusing. Let's use hand-picked names as we use in other gtk modules.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Blocks: wayland
Keywords: checkin-needed
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e7b7e9c3d61
[Wayland] remove PRETTY_FUNCTION from wayland logs as it produces too long function names, r=jhorak
Keywords: checkin-needed
Comment 3•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9091395 [details]
Bug 1579823 - [Wayland] remove PRETTY_FUNCTION from wayland logs as it produces too long function names, r=jhorak
Beta/Release Uplift Approval Request
- User impact if declined: Needed by Bug 1579849 to land. Also provides better logging for Wayland code.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only.
- String changes made/needed: none
Attachment #9091395 -
Flags: approval-mozilla-beta?
Comment 5•4 years ago
|
||
Comment on attachment 9091395 [details]
Bug 1579823 - [Wayland] remove PRETTY_FUNCTION from wayland logs as it produces too long function names, r=jhorak
Wayland fix, approved for 70.0b8.
Attachment #9091395 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•4 years ago
|
||
bugherder uplift |
status-firefox70:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•