Closed Bug 1579823 Opened 4 years ago Closed 4 years ago

[Wayland] remove __PRETTY_FUNCTION__ from wayland logs as it produces too long function names

Categories

(Core :: Widget: Gtk, enhancement)

Product:
Core
Component:
Widget: Gtk
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1579823 - [Wayland] remove __PRETTY_FUNCTION__ from wayland logs as it produces too long function names, r=jhorak
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review

PRETTY_FUNCTION is too long and makes the logs confusing. Let's use hand-picked names as we use in other gtk modules.

Depends on: 1579794
Blocks: wayland
Keywords: checkin-needed

Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e7b7e9c3d61
[Wayland] remove PRETTY_FUNCTION from wayland logs as it produces too long function names, r=jhorak

Keywords: checkin-needed

https://hg.mozilla.org/mozilla-central/rev/9e7b7e9c3d61

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Comment on attachment 9091395 [details]
Bug 1579823 - [Wayland] remove PRETTY_FUNCTION from wayland logs as it produces too long function names, r=jhorak

Beta/Release Uplift Approval Request

  • User impact if declined: Needed by Bug 1579849 to land. Also provides better logging for Wayland code.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only.
  • String changes made/needed: none
Attachment #9091395 - Flags: approval-mozilla-beta?

Comment on attachment 9091395 [details]
Bug 1579823 - [Wayland] remove PRETTY_FUNCTION from wayland logs as it produces too long function names, r=jhorak

Wayland fix, approved for 70.0b8.

Attachment #9091395 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.