StartVisitedQuery IPC is called many times on pageload
Categories
(Toolkit :: Places, enhancement)
Tracking
()
People
(Reporter: bas.schouten, Unassigned)
Details
Right now during pageload we see big batches of the StartVisitedQuery IPC call coming through. (hundreds in some cases) Since there is a relatively high overhead per IPDL call this hogs the I/O thread quite a bit as well. It would probably more efficient to batch these and send them in a single IPDL call.
Comment 1•5 years ago
|
||
http://mozilla.pettay.fi/moztests/linktest.html is a testcase, https://perfht.ml/2Q0b6bq a profile. The example is quite extreme
Comment 2•5 years ago
|
||
For GeckoView's history implementation, we buffer requests and wait for 250ms before sending an IPC message. There's a bug somewhere to use IdleTaskRunner
instead of a timer as a further optimization. It'd be wonderful if we could make that generic, so that GeckoView and Desktop Places could use the same logic to batch visited checks.
Comment 3•5 years ago
|
||
This is probably related to bug 484928 and might be a near duplicate of bug 1442659.
Comment 4•5 years ago
|
||
Discussed with Marco, and this is close enough to bug 1442659 that this is the same.
Description
•