Closed Bug 1580049 Opened Last month Closed Last month

newtab setting does not cleanup properly

Categories

(WebExtensions :: General, defect, P1)

defect

Tracking

(firefox70 fixed, firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I was hitting an intermittent failure in browser_ext_tabs_create_url.js where the expected newtab url was failing.

TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_create_url.js | Expected default URL of new tab - Expected: about:newtab, Actual: about:privatebrowsing -

I tracked it down to an error in logic in setNewTab where disable/removal was not handled correctly. In that case a couple prefs were left behind, even though the original value (about:newtab) was set. The prefs left behind changed the behavior of BROWSER_NEW_TAB_URL under specific (private browsing related) situations.

Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad9c659cc16d
fix clearing newtab prefs used by extensions r=robwu
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Flags: needinfo?(mixedpuppy)
Flags: needinfo?(mixedpuppy) → qe-verify-

Comment on attachment 9091611 [details]
Bug 1580049 fix clearing newtab prefs used by extensions

Beta/Release Uplift Approval Request

  • User impact if declined: Prefs are potentially left set if a newtab extension is disabled or uninstalled which can lead to some confusion in the newtab url handling.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): low risk, automated test checks the prefs are properly unset.
  • String changes made/needed: none
Attachment #9091611 - Flags: approval-mozilla-beta?

What versions are affected (is it a recent regression, or older?
Note, "verified in nightly" means someone other than the developer has verifed the fix by reproducing the issue in an older version, then testing with the fix.

Flags: needinfo?(mixedpuppy)

Comment on attachment 9091611 [details]
Bug 1580049 fix clearing newtab prefs used by extensions

Fix for a pref cleanup issue, adds new tests. OK for uplift for beta 9.

Attachment #9091611 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

(In reply to Liz Henry (:lizzard) from comment #6)

What versions are affected (is it a recent regression, or older?
Note, "verified in nightly" means someone other than the developer has verifed the fix by reproducing the issue in an older version, then testing with the fix.

This is probably a relatively old problem, however it (more specifically/generally issues in bug 1578508) is one that effects our line extensions and experiments which all are ramping up in quantity. There's a series of patches and bugs involved in addressing this to a level that will address most of the problem, but some later changes in other bugs might not be upliftable.

Flags: needinfo?(mixedpuppy)
You need to log in before you can comment on or make changes to this bug.