Closed Bug 1580080 Opened 6 years ago Closed 6 years ago

Simplify GCRuntime::findDeadCompartments by using a compartment to compartment map

Categories

(Core :: JavaScript: GC, task, P3)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: jonco, Unassigned)

Details

Attachments

(1 obsolete file)

This traverses all compartment to compartment edges for CCWs and debugger weak map entries. Currently this happens as part of its main loop. It would be simpler to build a map of these edges at the start of the method and then use it in the main loop. This is closer to what happens when we calculate sweep groups, which is similar.

This simplifies GCRuntime::findDeadCompartments and is the basis of future changes.

Depends on D45386

This is also no longer needed since the realisation in bug 1580205 comment 3. We can simplify this by backing out bug 1577146 instead.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Attachment #9091794 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: