Closed
Bug 1580087
Opened 5 years ago
Closed 5 years ago
fix a few places in imagelib that do 32bit * 32bit mutiples incorrectly
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
Details
Attachments
(1 file)
After the problem in bug 1284651, comment 9 I greped image/ for lines with the strings "width", "height" and "*". And fixed all the ones that needed fixing.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7793fa575497 Fix 32bit * 32bit integer multiplies so they don't overflow in imagelib. r=aosmond
|
||
Comment 3•5 years ago
|
||
Backed out changeset 7793fa575497 (Bug 1580087) for build bustages at nsIconChannel.cpp
Backout: https://hg.mozilla.org/integration/autoland/rev/0879b99736d84ff99ebc013fa30dabe1da067b36
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=7793fa575497587b04571a892b899fad9890f43c&selectedJob=266174550
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266174550&repo=autoland&lineNumber=20382
Flags: needinfo?(tnikkel)
|
||
Updated•5 years ago
|
Attachment #9091647 -
Attachment description: Bug 1580087. Fix 32bit * 32bit integer multiplies so they don't overflow in imagelib. r?aosmond → Bug 1580087. Fix 32bit * 32bit integer multiplies so they don't overflow in imagelib. r=aosmond
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/68594e925400 Fix 32bit * 32bit integer multiplies so they don't overflow in imagelib. r=aosmond
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(tnikkel)
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•