1580112 - Short looping video produces frequent disk activity

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Kestrel]

STR:

1. Display a short looping video (eg https://imgur.com/a/WJfq5n6).

Expected:

No disk activity, silent HDD.

Actual:

Disk activity occurs every time the video loops. For HDDs this produces an audible ticking sound, indicating that writes are not being buffered. The prolonged nature of these frequent writes may cause unnecessary wear to storage devices.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=adc36d5fd87a2476edb63435c3ff9d19e731262c&tochange=eed72505cf9b3c968aced5a6488f2660e1f02da4

Regressed by Bug 1530996.

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1580112 - Stop updating the database when the value has not changed. r?alwu

In most of the cases, the value to be stored is the same as the existing value, which does not require an update to the database. Setting something in the database requires disk access. By using this we avoid accessing the disk in the majority of the cases.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e6f8b858af7
Stop updating the database when the value has not changed. r=alwu

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2e6f8b858af7

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta uplift when you get a chance.

Comment 5

[Alex Chronopoulos [:achronop]]

Comment on attachment 9092027 [details]
Bug 1580112 - Stop updating the database when the value has not changed. r?alwu

Beta/Release Uplift Approval Request

• User impact if declined: Frequent disk activity when a short looping video plays on the loop
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No risky, very small fix that improves the performance when a video is being played on a loop.
• String changes made/needed: N/A

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9092027 [details]
Bug 1580112 - Stop updating the database when the value has not changed. r?alwu

Avoids doing useless work, approved for 70.0b8.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5433da8d8132